From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:53599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gh1Zz-0006iq-9K for qemu-devel@nongnu.org; Tue, 08 Jan 2019 19:18:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gh1Zy-0001FG-5L for qemu-devel@nongnu.org; Tue, 08 Jan 2019 19:18:43 -0500 Received: from mga18.intel.com ([134.134.136.126]:13202) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gh1Zx-00017T-T6 for qemu-devel@nongnu.org; Tue, 08 Jan 2019 19:18:42 -0500 References: <1546900184-27403-1-git-send-email-venu.busireddy@oracle.com> <1546900184-27403-2-git-send-email-venu.busireddy@oracle.com> <6f5632f5-1469-7000-9b92-ef2564a63f63@oracle.com> <20190108172522.GA28457@troi> <41b85d40-0711-a0f3-6b45-bacd20644186@oracle.com> From: "Samudrala, Sridhar" Message-ID: Date: Tue, 8 Jan 2019 16:18:24 -0800 MIME-Version: 1.0 In-Reply-To: <41b85d40-0711-a0f3-6b45-bacd20644186@oracle.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 1/5] virtio_net: Add VIRTIO_NET_F_STANDBY feature bit. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dongli Zhang , Venu Busireddy Cc: virtio-dev@lists.oasis-open.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Marcel Apfelbaum , si-wei.liu@oracle.com On 1/8/2019 4:14 PM, Dongli Zhang wrote: > Hi Venu, > > On 2019/1/9 上午1:25, Venu Busireddy wrote: >> On 2019-01-09 00:56:38 +0800, Dongli Zhang wrote: >>> I am not familiar with libvirt and I would like to play with this only with qemu. >>> >>> With failover, we need to hotplug the VF on destination server to VM after live >>> migration. However, the VF on destination server would have different mac address. >>> >>> How can we specify the mac for the new VF to hotplug via qemu, as VF is only a >>> vfio pci device? >> How is the VF device on the destination host any different from the VF >> on the source host? >> >> As you do on the source host, you first assign the MAC address of >> 00:00:00:00:00:00 to the VF. After the migration, you assign the same >> MAC address as that of the virtio_net device to the VF, and hotadd the VF > This was what I was wondering. > > How the mac address is configured for VF (or any NIC like PF) after it is > assigned to vfio? ip link set vf    mac See https://www.kernel.org/doc/html/latest/networking/net_failover.html for a sample script that shows the steps to initiate live migration with VF and virtio-net in standby mode. > > Thank you very much! > > Dongli Zhang > > >> device to the VM. And then, after you receive the FAILOVER_PRIMARY_CHANGED >> event, set the macvtap device to down state. >> >> Venu >> >>> I am trying to play with this with only qemu (w/o libvirt). >>> >>> Thank you very much! >>> >>> Dongli Zhang >>> >>> On 01/08/2019 06:29 AM, Venu Busireddy wrote: >>>> From: Sridhar Samudrala >>>> >>>> This feature bit can be used by a hypervisor to indicate to the virtio_net >>>> device that it can act as a standby for another device with the same MAC >>>> address. >>>> >>>> Signed-off-by: Sridhar Samudrala >>>> Signed-off-by: Venu Busireddy >>>> --- >>>> hw/net/virtio-net.c | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c >>>> index 385b1a0..411f8fb 100644 >>>> --- a/hw/net/virtio-net.c >>>> +++ b/hw/net/virtio-net.c >>>> @@ -2198,6 +2198,8 @@ static Property virtio_net_properties[] = { >>>> true), >>>> DEFINE_PROP_INT32("speed", VirtIONet, net_conf.speed, SPEED_UNKNOWN), >>>> DEFINE_PROP_STRING("duplex", VirtIONet, net_conf.duplex_str), >>>> + DEFINE_PROP_BIT64("standby", VirtIONet, host_features, VIRTIO_NET_F_STANDBY, >>>> + false), >>>> DEFINE_PROP_END_OF_LIST(), >>>> }; >>>> >>>>