From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: peter.maydell@linaro.org, frederic.konrad@adacore.com,
alistair@alistair23.me, luc.michel@greensocs.com,
frasse.iglesias@gmail.com, figlesia@xilinx.com,
sstabellini@kernel.org, sai.pavan.boddu@xilinx.com,
edgar.iglesias@xilinx.com
Subject: Re: [Qemu-devel] [PATCH v1 1/1] hw/arm: versal: Plug memory leaks
Date: Fri, 4 Jan 2019 13:10:23 +0100 [thread overview]
Message-ID: <ae299994-887b-395c-880c-8c69a02e2ef3@redhat.com> (raw)
In-Reply-To: <20190104104749.5314-2-edgar.iglesias@gmail.com>
On 1/4/19 11:47 AM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Plug a couple of "board creation time" memory leaks.
>
Fixes 6f16da53ffe
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/arm/xlnx-versal-virt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c
> index c6feeac532..f95fde2309 100644
> --- a/hw/arm/xlnx-versal-virt.c
> +++ b/hw/arm/xlnx-versal-virt.c
> @@ -130,6 +130,7 @@ static void fdt_add_gic_nodes(VersalVirt *s)
> 2, MM_GIC_APU_REDIST_0_SIZE);
> qemu_fdt_setprop_cell(s->fdt, nodename, "#interrupt-cells", 3);
> qemu_fdt_setprop_string(s->fdt, nodename, "compatible", "arm,gic-v3");
> + g_free(nodename);
> }
>
> static void fdt_add_timer_nodes(VersalVirt *s)
> @@ -364,6 +365,7 @@ static void create_virtio_regions(VersalVirt *s)
> sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, pic_irq);
> mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(dev), 0);
> memory_region_add_subregion(&s->soc.mr_ps, base, mr);
> + g_free(name);
> }
>
> for (i = 0; i < NUM_VIRTIO_TRANSPORT; i++) {
>
next prev parent reply other threads:[~2019-01-04 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 10:47 [Qemu-devel] [PATCH v1 0/1] hw/arm: versal: Fix memory leaks Edgar E. Iglesias
2019-01-04 10:47 ` [Qemu-devel] [PATCH v1 1/1] hw/arm: versal: Plug " Edgar E. Iglesias
2019-01-04 12:10 ` Philippe Mathieu-Daudé [this message]
2019-01-04 15:18 ` [Qemu-devel] [PATCH v1 0/1] hw/arm: versal: Fix " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae299994-887b-395c-880c-8c69a02e2ef3@redhat.com \
--to=philmd@redhat.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=figlesia@xilinx.com \
--cc=frasse.iglesias@gmail.com \
--cc=frederic.konrad@adacore.com \
--cc=luc.michel@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sai.pavan.boddu@xilinx.com \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).