Re: [PATCH v3 11/19] pc-bios/s390-ccw: Remove panics from Netboot IPL path

[Jared Rossi <jrossi@linux.ibm.com>]

On 10/9/24 7:35 AM, Thomas Huth wrote:
> On 08/10/2024 03.15, jrossi@linux.ibm.com wrote:
>> From: Jared Rossi <jrossi@linux.ibm.com>
>>
>> Remove panic-on-error from Netboot specific functions so that error 
>> recovery
>> may be possible in the future.
>>
>> Functions that would previously panic now provide a return code.
>>
>> Signed-off-by: Jared Rossi <jrossi@linux.ibm.com>
>> ---
> ...
>> diff --git a/pc-bios/s390-ccw/netmain.c b/pc-bios/s390-ccw/netmain.c
>> index bc6ad8695f..0c2329c752 100644
>> --- a/pc-bios/s390-ccw/netmain.c
>> +++ b/pc-bios/s390-ccw/netmain.c
>> @@ -464,7 +464,7 @@ static bool find_net_dev(Schib *schib, int dev_no)
>>       return false;
>>   }
>>   -static void virtio_setup(void)
>> +static int virtio_setup(void)
>
> Maybe better use "bool" instead of "int" here...
>
>>   {
>>       Schib schib;
>>       int ssid;
>> @@ -495,10 +495,10 @@ static void virtio_setup(void)
>>           }
>>       }
>>   -    IPL_assert(found, "No virtio net device found");
>> +    return found;
>
> ... since the function obviously returns a boolean value.
>
>  Thomas
>

Fixed, changed return type to bool.

     Jared