* [Qemu-devel] [PATCH] i386: Remove osxsave CPUID flag name
@ 2018-06-11 20:38 Eduardo Habkost
2018-06-11 21:49 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Eduardo Habkost @ 2018-06-11 20:38 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Richard Henderson, Eduardo Habkost
OSXAVE is not a static feature flag: it changes dynamically at
runtime depending on CR4, and it was never configurable: KVM
never returned OSXSAVE on GET_SUPPORTED_CPUID, and it is not
included in TCG_EXT_FEATURES.
Remove OSXSAVE from the feature name array so users don't try to
configure it manually.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target/i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 94260412e2..ae9e8a489b 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -614,7 +614,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
"fma", "cx16", "xtpr", "pdcm",
NULL, "pcid", "dca", "sse4.1",
"sse4.2", "x2apic", "movbe", "popcnt",
- "tsc-deadline", "aes", "xsave", "osxsave",
+ "tsc-deadline", "aes", "xsave", NULL /* osxsave */,
"avx", "f16c", "rdrand", "hypervisor",
},
.cpuid_eax = 1, .cpuid_reg = R_ECX,
--
2.18.0.rc1.1.g3f1ff2140
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] i386: Remove osxsave CPUID flag name
2018-06-11 20:38 [Qemu-devel] [PATCH] i386: Remove osxsave CPUID flag name Eduardo Habkost
@ 2018-06-11 21:49 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2018-06-11 21:49 UTC (permalink / raw)
To: Eduardo Habkost, qemu-devel; +Cc: Paolo Bonzini
On 06/11/2018 10:38 AM, Eduardo Habkost wrote:
> OSXAVE is not a static feature flag: it changes dynamically at
> runtime depending on CR4, and it was never configurable: KVM
> never returned OSXSAVE on GET_SUPPORTED_CPUID, and it is not
> included in TCG_EXT_FEATURES.
>
> Remove OSXSAVE from the feature name array so users don't try to
> configure it manually.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-11 21:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-11 20:38 [Qemu-devel] [PATCH] i386: Remove osxsave CPUID flag name Eduardo Habkost
2018-06-11 21:49 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).