Re: [Qemu-devel] [PATCH 3/5] tricore: fixed wrong masking of IE

[Bastian Koppelmann <kbastian@mail.uni-paderborn.de>]

On 02/19/2018 07:18 AM, David Brenken wrote:
> From: David Brenken <david.brenken@efs-auto.de>
> 
> Signed-off-by: David Brenken <david.brenken@efs-auto.de>
> Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
> Signed-off-by: Florian Artmeier <florian.artmeier@efs-auto.de>
> ---
>  target/tricore/cpu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/tricore/cpu.h b/target/tricore/cpu.h
> index c295763..6ed474c 100644
> --- a/target/tricore/cpu.h
> +++ b/target/tricore/cpu.h
> @@ -257,7 +257,7 @@ void tricore_cpu_dump_state(CPUState *cpu, FILE *f,
>  #define MASK_CPUID_REV     0x000000ff
>  
>  #define MASK_ICR_PIPN 0x00ff0000
> -#define MASK_ICR_IE   0x00000100
> +#define MASK_ICR_IE   0x00008000
>  #define MASK_ICR_CCPN 0x000000ff
>  
>  #define MASK_FCX_FCXS 0x000f0000
> 

This is architecture specific. You propose the mask for 1.6+ CPUs. The
original is for 1.3 CPUs. You could rename the original mask to
something like MASK_ICR_IE_1_3 and add your own MASK_ICR_IE_1_6 mask.

Cheers,
Bastian