From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A5DC43603 for ; Fri, 20 Dec 2019 09:53:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CCD92465E for ; Fri, 20 Dec 2019 09:53:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hYbU6HjW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CCD92465E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiEy7-0002W2-9Q for qemu-devel@archiver.kernel.org; Fri, 20 Dec 2019 04:53:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47987) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiExJ-0001av-AR for qemu-devel@nongnu.org; Fri, 20 Dec 2019 04:52:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iiExI-0006jm-38 for qemu-devel@nongnu.org; Fri, 20 Dec 2019 04:52:21 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:44795 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iiExH-0006gM-NC for qemu-devel@nongnu.org; Fri, 20 Dec 2019 04:52:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576835539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=B09PvgsdD6AGGPKN1cyPCaacz4FMOJpiO/QhMw28MlI=; b=hYbU6HjWWubFMHUNt3DFMCqQ+Hsj5Nmm+BidE1eV4JnVeh0yicox6DKdhb5tHV4gIjg73j s4knLH+aligF7KPE+KctVLd7g2X2X123Jcm0x0ybz9nMp0NC5zgsgX47G1e9OZEaxubNFX 1Oh9yKYD1gmhwuWuwc+oB1AFJ43z4OA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-117-GfoWXcTYON20Grch70Fnsg-1; Fri, 20 Dec 2019 04:52:10 -0500 X-MC-Unique: GfoWXcTYON20Grch70Fnsg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 194B7DB63; Fri, 20 Dec 2019 09:52:09 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-205-117.brq.redhat.com [10.40.205.117]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EF5560BF3; Fri, 20 Dec 2019 09:52:07 +0000 (UTC) Subject: Re: [PATCH v2] iotests.py: Let wait_migration wait even more To: Kevin Wolf References: <20191219183617.213637-1-mreitz@redhat.com> <20191220093258.GB4019@dhcp-200-226.str.redhat.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Fri, 20 Dec 2019 10:52:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191220093258.GB4019@dhcp-200-226.str.redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7P6FyxHjaXkACZY1FYIeaR7xQcuSd91uP" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7P6FyxHjaXkACZY1FYIeaR7xQcuSd91uP Content-Type: multipart/mixed; boundary="SuxPBYrBEyvTjVtFrQoSnpM0OaCzT8vro" --SuxPBYrBEyvTjVtFrQoSnpM0OaCzT8vro Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 20.12.19 10:32, Kevin Wolf wrote: > Am 19.12.2019 um 19:36 hat Max Reitz geschrieben: >> The "migration completed" event may be sent (on the source, to be >> specific) before the migration is actually completed, so the VM runstate >> will still be "finish-migrate" instead of "postmigrate". So ask the >> users of VM.wait_migration() to specify the final runstate they desire >> and then poll the VM until it has reached that state. (This should be >> over very quickly, so busy polling is fine.) >> >> Without this patch, I see intermittent failures in the new iotest 280 >> under high system load. I have not yet seen such failures with other >> iotests that use VM.wait_migration() and query-status afterwards, but >> maybe they just occur even more rarely, or it is because they also wait >> on the destination VM to be running. >> >> Signed-off-by: Max Reitz >=20 >> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.= py >> index 13fd8b5cd2..0b62c42851 100644 >> --- a/tests/qemu-iotests/iotests.py >> +++ b/tests/qemu-iotests/iotests.py >> @@ -668,12 +668,16 @@ class VM(qtest.QEMUQtestMachine): >> } >> ])) >> =20 >> - def wait_migration(self): >> + def wait_migration(self, expect_runstate): >> while True: >> event =3D self.event_wait('MIGRATION') >> log(event, filters=3D[filter_qmp_event]) >> if event['data']['status'] =3D=3D 'completed': >> break >> + # The event may occur in finish-migrate, so wait for the expect= ed >> + # post-migration runstate >=20 > That's a bit too specific now that you have expect_runstate. Can you be more specific? :-) If you mean the fact of mentioning =E2=80=9Cpost-migration runstate=E2=80= =9D, I simply meant that as =E2=80=9Cthe runstate after the migration=E2=80=9D. The spec= ific runstate on the source VM is called =E2=80=9Cpostmigrate=E2=80=9D. I wouldn=E2=80=99t mind changing it to =E2=80=9Cafter-migration runstate=E2= =80=9D or something similar, if that=E2=80=99s what you mean. Max >> + while self.qmp('query-status')['return']['status'] !=3D expect_= runstate: >> + pass >> =20 >> def node_info(self, node_name): >> nodes =3D self.qmp('query-named-block-nodes') >=20 > Tested-by: Kevin Wolf >=20 --SuxPBYrBEyvTjVtFrQoSnpM0OaCzT8vro-- --7P6FyxHjaXkACZY1FYIeaR7xQcuSd91uP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl38mcUACgkQ9AfbAGHV z0BW2Qf/RgbrNmxIhQimvyHGh3ap4EnlFyv6P97FzkCb8ppmTR+G+ony/3hOH5Lb d2zSFtT4zmZE0tfeKEMXZrtVFRoVGBaLestNjHT0kP33PVWtJ5MYQhg0V8V4GGDw UX/l453hXugoMKm0PNLL3iI7sq27590ZUkEXirAHR3tn+vEiwD1Z743Jh+MWhWzf 5kg9xoJ1ZmtFT3Ghp5vANnuraCgZPry+wr61AX8pY4yql5Ca9zsmK38ItUgQPgBO UJFL19gTagXNssxYvhvJVP6gexgA7Sk2NwoMXGTkSSxDSYoCHmPIHr2p8/5lKQ6m yfAXQDTy62O4b4blWTXCprs9dkOMPQ== =5HAG -----END PGP SIGNATURE----- --7P6FyxHjaXkACZY1FYIeaR7xQcuSd91uP--