* [PATCH] target/s390x: Fix a typo in s390_cpu_class_init()
@ 2025-03-23 15:30 Philippe Mathieu-Daudé
2025-03-23 19:20 ` Richard Henderson
2025-03-24 6:05 ` Thomas Huth
0 siblings, 2 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-03-23 15:30 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Richard Henderson, Ilya Leoshkevich,
David Hildenbrand, qemu-s390x, Philippe Mathieu-Daudé
Fixes: 41868f846d2 ("s390x/cpumodel: "host" and "qemu" as CPU subclasses")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/s390x/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
index d73142600bf..1f75629ddc2 100644
--- a/target/s390x/cpu.c
+++ b/target/s390x/cpu.c
@@ -377,7 +377,7 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data)
resettable_class_set_parent_phases(rc, NULL, s390_cpu_reset_hold, NULL,
&scc->parent_phases);
- cc->class_by_name = s390_cpu_class_by_name,
+ cc->class_by_name = s390_cpu_class_by_name;
cc->mmu_index = s390x_cpu_mmu_index;
cc->dump_state = s390_cpu_dump_state;
cc->query_cpu_fast = s390_query_cpu_fast;
--
2.47.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] target/s390x: Fix a typo in s390_cpu_class_init()
2025-03-23 15:30 [PATCH] target/s390x: Fix a typo in s390_cpu_class_init() Philippe Mathieu-Daudé
@ 2025-03-23 19:20 ` Richard Henderson
2025-03-24 6:05 ` Thomas Huth
1 sibling, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2025-03-23 19:20 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Thomas Huth, Ilya Leoshkevich, David Hildenbrand, qemu-s390x
On 3/23/25 08:30, Philippe Mathieu-Daudé wrote:
> Fixes: 41868f846d2 ("s390x/cpumodel: "host" and "qemu" as CPU subclasses")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/s390x/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
> index d73142600bf..1f75629ddc2 100644
> --- a/target/s390x/cpu.c
> +++ b/target/s390x/cpu.c
> @@ -377,7 +377,7 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data)
> resettable_class_set_parent_phases(rc, NULL, s390_cpu_reset_hold, NULL,
> &scc->parent_phases);
>
> - cc->class_by_name = s390_cpu_class_by_name,
> + cc->class_by_name = s390_cpu_class_by_name;
> cc->mmu_index = s390x_cpu_mmu_index;
> cc->dump_state = s390_cpu_dump_state;
> cc->query_cpu_fast = s390_query_cpu_fast;
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] target/s390x: Fix a typo in s390_cpu_class_init()
2025-03-23 15:30 [PATCH] target/s390x: Fix a typo in s390_cpu_class_init() Philippe Mathieu-Daudé
2025-03-23 19:20 ` Richard Henderson
@ 2025-03-24 6:05 ` Thomas Huth
2025-03-24 16:33 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2025-03-24 6:05 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Richard Henderson, Ilya Leoshkevich, David Hildenbrand,
qemu-s390x
On 23/03/2025 16.30, Philippe Mathieu-Daudé wrote:
> Fixes: 41868f846d2 ("s390x/cpumodel: "host" and "qemu" as CPU subclasses")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/s390x/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
> index d73142600bf..1f75629ddc2 100644
> --- a/target/s390x/cpu.c
> +++ b/target/s390x/cpu.c
> @@ -377,7 +377,7 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data)
> resettable_class_set_parent_phases(rc, NULL, s390_cpu_reset_hold, NULL,
> &scc->parent_phases);
>
> - cc->class_by_name = s390_cpu_class_by_name,
> + cc->class_by_name = s390_cpu_class_by_name;
Please add a proper patch description next time. I spent dozens of seconds
to spot the typo in one of the words 'til I realized that it is the comma at
the end ;-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] target/s390x: Fix a typo in s390_cpu_class_init()
2025-03-24 6:05 ` Thomas Huth
@ 2025-03-24 16:33 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-03-24 16:33 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: Richard Henderson, Ilya Leoshkevich, David Hildenbrand,
qemu-s390x
On 24/3/25 07:05, Thomas Huth wrote:
> On 23/03/2025 16.30, Philippe Mathieu-Daudé wrote:
>> Fixes: 41868f846d2 ("s390x/cpumodel: "host" and "qemu" as CPU
>> subclasses")
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> target/s390x/cpu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
>> index d73142600bf..1f75629ddc2 100644
>> --- a/target/s390x/cpu.c
>> +++ b/target/s390x/cpu.c
>> @@ -377,7 +377,7 @@ static void s390_cpu_class_init(ObjectClass *oc,
>> void *data)
>> resettable_class_set_parent_phases(rc, NULL,
>> s390_cpu_reset_hold, NULL,
>> &scc->parent_phases);
>> - cc->class_by_name = s390_cpu_class_by_name,
>> + cc->class_by_name = s390_cpu_class_by_name;
>
> Please add a proper patch description next time. I spent dozens of
> seconds to spot the typo in one of the words 'til I realized that it is
> the comma at the end ;-)
Sorry I thought it was trivial, but since it got unnoticed during
8 years, maybe not.
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-24 16:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-23 15:30 [PATCH] target/s390x: Fix a typo in s390_cpu_class_init() Philippe Mathieu-Daudé
2025-03-23 19:20 ` Richard Henderson
2025-03-24 6:05 ` Thomas Huth
2025-03-24 16:33 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).