qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Deepa Srinivasan <deepas@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: kvm-ppc@vger.kernel.org
Subject: [Qemu-devel] [PATCH] qemu: Fix incorrect zlib check error
Date: Fri, 14 Nov 2008 11:57:47 -0600	[thread overview]
Message-ID: <ae59be00a22c4769a111.1226685467@440dev.austin.ibm.com> (raw)

# HG changeset patch
# User Deepa Srinivasan <deepas@us.ibm.com>
# Date 1226685276 21600
# Node ID ae59be00a22c4769a1116943ca5e07cec9154de0
# Parent  1a74ac23ff60cc2ab052072243dc4ff47faf5849
qemu: Fix incorrect zlib check error

From: Deepa Srinivasan <deepas@us.ibm.com>

Include the CFLAGS and LDFLAGS variables in the check for zlib. When cross-compiling
for PowerPC, the path for zlib headers and libraries are passed in the CFLAGS
and LDFLAGS respectively. While this patch fixes only the check for zlib,
this issue potentially affects other configure tests as well.

Signed-off-by: Deepa Srinivasan <deepas@us.ibm.com>
---

[diffstat]
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[diff]

diff -r 1a74ac23ff60 -r ae59be00a22c qemu/configure
--- a/qemu/configure	Fri Nov 14 10:53:36 2008 -0600
+++ b/qemu/configure	Fri Nov 14 11:54:36 2008 -0600
@@ -798,7 +798,7 @@ cat > $TMPC << EOF
 #include <zlib.h>
 int main(void) { zlibVersion(); return 0; }
 EOF
-if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $TMPC -lz 2> /dev/null ; then
+if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $CFLAGS $LDFLAGS $TMPC -lz 2> /dev/null ; then
     :
 else
     echo

             reply	other threads:[~2008-11-14 18:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-14 17:57 Deepa Srinivasan [this message]
2008-11-18 20:41 ` [Qemu-devel] [PATCH] qemu: Fix incorrect zlib check error Hollis Blanchard
2008-11-18 22:11   ` Anthony Liguori
2008-11-18 22:12 ` Anthony Liguori
2008-11-25  2:38   ` Deepa Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae59be00a22c4769a111.1226685467@440dev.austin.ibm.com \
    --to=deepas@us.ibm.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).