From: shiliyang <shiliyang@huawei.com>
To: Warner Losh <imp@bsdimp.com>
Cc: alex.chen@huawei.com, Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
hunongda@huawei.com
Subject: Re: [PATCH V3 0/4] bsd-user: Fix some code style problems
Date: Thu, 14 Jan 2021 14:42:42 +0800 [thread overview]
Message-ID: <ae6378f4-e82d-c0c7-40e8-2d5ebe4f125e@huawei.com> (raw)
In-Reply-To: <CANCZdfr9Fd+Ne3cGqhHfna+iAD9bwe=ScbzN1C+uads8RqJDsQ@mail.gmail.com>
On 2021/1/14 6:03, Warner Losh wrote:
> While these changes look good, can you submit this against the bsd-user repository? White space changes like this in mainline make rebasing harder than needed.
>
> https://github.com/qemu-bsd-user/qemu-bsd-user <https://github.com/qemu-bsd-user/qemu-bsd-user> branch bsd-user-rebase-3.1and we'll make sure they get via our coming pull requests..
>
> Warner
>
> On Wed, Jan 13, 2021 at 2:31 AM shiliyang <shiliyang@huawei.com <mailto:shiliyang@huawei.com>> wrote:
>
> This patch series fixes error style problems found by checkpatch.pl <http://checkpatch.pl>.
>
> V2->V3:
> Make the patch into a series.
>
> V1->V2:
> Add cover letter message.
> Fix some style error in patch file before.
>
> Liyang Shi (4):
> bsd-user: "foo * bar" should be "foo *bar"
> bsd-user: suspect code indent for conditional statements
> bsd-user: space required after semicolon
> bsd-user: do not use C99 // comments
>
> bsd-user/bsdload.c | 6 +++---
> bsd-user/elfload.c | 38 +++++++++++++++++++-------------------
> bsd-user/qemu.h | 14 +++++++-------
> bsd-user/syscall.c | 6 +++---
> 4 files changed, 32 insertions(+), 32 deletions(-)
>
> --
> 2.29.1.59.gf9b6481aed
>
>
OK, I get it, thanks!
Best regards.
prev parent reply other threads:[~2021-01-14 6:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 9:30 [PATCH V3 0/4] bsd-user: Fix some code style problems shiliyang
2021-01-13 9:31 ` [PATCH V3 1/4] bsd-user: "foo * bar" should be "foo *bar" shiliyang
2021-01-13 9:32 ` [PATCH V3 2/4] bsd-user: suspect code indent for conditional statements shiliyang
2021-01-13 9:32 ` [PATCH V3 3/4] bsd-user: space required after semicolon shiliyang
2021-01-13 9:33 ` [PATCH V3 4/4] bsd-user: do not use C99 // comments shiliyang
2021-01-13 22:03 ` [PATCH V3 0/4] bsd-user: Fix some code style problems Warner Losh
2021-01-14 6:42 ` shiliyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae6378f4-e82d-c0c7-40e8-2d5ebe4f125e@huawei.com \
--to=shiliyang@huawei.com \
--cc=alex.chen@huawei.com \
--cc=hunongda@huawei.com \
--cc=imp@bsdimp.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).