qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 1/7] Unbreak USB autoconnect filters
Date: Wed,  7 Oct 2009 01:15:55 +0200	[thread overview]
Message-ID: <ae674d554caf119dbd57bda4ecea2a7dd6069260.1254867902.git.armbru@redhat.com> (raw)
In-Reply-To: <cover.1254867902.git.armbru@redhat.com>

Commit 22f84e73 added a qdev_init() missing on the path through
usb_host_device_open(), but that broke the path through
usb_host_auto_scan(), which already had one.  Remove that one.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 usb-linux.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/usb-linux.c b/usb-linux.c
index 2b7b092..77cbf1b 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -1396,8 +1396,6 @@ static int usb_host_auto_scan(void *opaque, int bus_num, int addr,
         dprintf("husb: auto open: bus_num %d addr %d\n", bus_num, addr);
 
 	dev = usb_host_device_open_addr(bus_num, addr, product_name);
-	if (dev)
-            qdev_init(&dev->qdev);
     }
 
     return 0;
-- 
1.6.2.5

  reply	other threads:[~2009-10-06 23:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-06 23:15 [Qemu-devel] [PATCH 0/7] Clean up use of qdev_init() Markus Armbruster
2009-10-06 23:15 ` Markus Armbruster [this message]
2009-10-06 23:15 ` [Qemu-devel] [PATCH 2/7] Make qdev_init() destroy the device on failure Markus Armbruster
2009-10-06 23:15 ` [Qemu-devel] [PATCH 3/7] Check return value of qdev_init() Markus Armbruster
2009-10-06 23:15 ` [Qemu-devel] [PATCH 4/7] New qdev_init_nofail() Markus Armbruster
2009-10-06 23:15 ` [Qemu-devel] [PATCH 5/7] Make isa_create() terminate program on failure Markus Armbruster
2009-10-06 23:16 ` [Qemu-devel] [PATCH 6/7] Warn if value of qdev_init() isn't checked Markus Armbruster
2009-10-06 23:16 ` [Qemu-devel] [PATCH 7/7] Clean up test for qdev_init() failure Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae674d554caf119dbd57bda4ecea2a7dd6069260.1254867902.git.armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).