From: Axel Heider <axelheider@gmx.de>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH qemu.git 04/11] hw/timer/imx_epit: remove explicit fields cnt and freq
Date: Tue, 1 Nov 2022 22:15:03 +0100 [thread overview]
Message-ID: <ae6a8bc8-91c3-678b-a2e3-c23be657d065@gmx.de> (raw)
In-Reply-To: <7f03ab9a-5f00-684a-f644-dc16b1cca7cf@linaro.org>
-------- Original Message --------
> From: Philippe Mathieu-Daudé [mailto:philmd@linaro.org]> diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c>
> index a79f58c963..37b04a1b53 100644
> --- a/hw/timer/imx_epit.c
> +++ b/hw/timer/imx_epit.c
> @@ -77,23 +77,25 @@ static void imx_epit_update_int(IMXEPITState *s)
> * Must be called from within a ptimer_transaction_begin/commit block
> * for both s->timer_cmp and s->timer_reload.
> */
> -static void imx_epit_set_freq(IMXEPITState *s)
> +static uint32_t imx_epit_set_freq(IMXEPITState *s)
>
> Maybe rename as imx_epit_get_freq() or simply imx_epit_freq(),
>
There will be an update of the whole patchset, so I will change
the name to imx_epit_freq(). That makes the name and signature in
sync. Note that the next commit in this patchset does more
refactoring anyway, so this is just a intermediate change that
is not really visible.
Axel
next prev parent reply other threads:[~2022-11-01 21:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 2:15 [PATCH qemu.git 00/11] improve hw/timer/imx_epit ~axelheider
2022-10-25 10:33 ` [PATCH qemu.git 04/11] hw/timer/imx_epit: remove explicit fields cnt and freq ~axelheider
2022-10-31 8:19 ` Philippe Mathieu-Daudé
2022-11-01 21:15 ` Axel Heider [this message]
2022-10-25 11:23 ` [PATCH qemu.git 05/11] hw/timer/imx_epit: simplify interrupt logic ~axelheider
2022-10-25 11:51 ` [PATCH qemu.git 01/11] hw/timer/imx_epit: fix typo in comment ~axelheider
2022-10-25 15:33 ` [PATCH qemu.git 02/11] hw/timer/imx_epit: improve comments ~axelheider
2022-10-31 8:20 ` Philippe Mathieu-Daudé
2022-10-25 18:06 ` [PATCH qemu.git 07/11] hw/timer/imx_epit: do not persist CR.SWR bit ~axelheider
2022-10-25 18:32 ` [PATCH qemu.git 06/11] hw/timer/imx_epit: software reset clears the interrupt ~axelheider
2022-10-31 8:21 ` Philippe Mathieu-Daudé
2022-10-27 13:09 ` [PATCH qemu.git 03/11] hw/timer/imx_epit: factor out register write handlers ~axelheider
2022-10-29 16:41 ` [PATCH qemu.git 08/11] hw/timer/imx_epit: simplify CR.ENMOD handling ~axelheider
2022-10-31 8:22 ` Philippe Mathieu-Daudé
2022-10-30 23:59 ` [PATCH qemu.git 09/11] hw/timer/imx_epit: cleanup CR defines ~axelheider
2022-10-31 8:23 ` Philippe Mathieu-Daudé
2022-10-31 0:25 ` [PATCH qemu.git 10/11] hw/timer/imx_epit: fix compare timer update ~axelheider
2022-10-31 0:28 ` [PATCH qemu.git 11/11] hw/timer/imx_epit: rework CR write handling ~axelheider
2022-10-31 8:25 ` Philippe Mathieu-Daudé
2022-11-01 21:19 ` Axel Heider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae6a8bc8-91c3-678b-a2e3-c23be657d065@gmx.de \
--to=axelheider@gmx.de \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).