qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org, David Woodhouse <dwmw2@infradead.org>,
	"open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>,
	Paul Durrant <paul@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony@xenproject.org>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	qemu-arm <qemu-arm@nongnu.org>, "Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PULL 3/9] meson: Disallow 64-bit on 32-bit Xen emulation
Date: Tue, 18 Feb 2025 12:20:07 +0100	[thread overview]
Message-ID: <aeaf0f19-0f14-4a02-9c51-09521e7c75e1@linaro.org> (raw)
In-Reply-To: <20250208205725.568631-4-richard.henderson@linaro.org>

Hi,

Adding Xen community.

On 8/2/25 21:57, Richard Henderson wrote:
> Require a 64-bit host binary to spawn a 64-bit guest.
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   meson.build | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 1af8aeb194..911955cfa8 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -304,9 +304,14 @@ else
>   endif
>   accelerator_targets = { 'CONFIG_KVM': kvm_targets }
>   
> -if cpu in ['x86', 'x86_64']
> +if cpu == 'x86'
> +  xen_targets = ['i386-softmmu']
> +elif cpu == 'x86_64'
>     xen_targets = ['i386-softmmu', 'x86_64-softmmu']
> -elif cpu in ['arm', 'aarch64']
> +elif cpu == 'arm'
> +  # i386 emulator provides xenpv machine type for multiple architectures
> +  xen_targets = ['i386-softmmu']

Is actually someone *testing* this config? I'm having hard time building
it, so am very suspicious about how it runs, and start to wonder if I'm
not just wasting my time (as could be our CI).

> +elif cpu == 'aarch64'
>     # i386 emulator provides xenpv machine type for multiple architectures
>     xen_targets = ['i386-softmmu', 'x86_64-softmmu', 'aarch64-softmmu']
>   else

Regards,

Phil.



  reply	other threads:[~2025-02-18 11:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-08 20:57 [PULL 0/9] meson: Disallow 64-bit on 32-bit emulation Richard Henderson
2025-02-08 20:57 ` [PULL 1/9] meson: Drop tcg as a module Richard Henderson
2025-02-08 20:57 ` [PULL 2/9] meson: Disallow 64-bit on 32-bit KVM emulation Richard Henderson
2025-02-08 20:57 ` [PULL 3/9] meson: Disallow 64-bit on 32-bit Xen emulation Richard Henderson
2025-02-18 11:20   ` Philippe Mathieu-Daudé [this message]
2025-02-18 13:19     ` Philippe Mathieu-Daudé
2025-02-18 13:20       ` Philippe Mathieu-Daudé
2025-02-18 14:10     ` Andrew Cooper
2025-02-18 15:25       ` Philippe Mathieu-Daudé
2025-02-18 15:41         ` Philippe Mathieu-Daudé
2025-02-18 19:30       ` Stefano Stabellini
2025-02-08 20:57 ` [PULL 4/9] meson: Disallow 64-bit on 32-bit HVF/NVMM/WHPX emulation Richard Henderson
2025-02-08 20:57 ` [PULL 5/9] gitlab-ci: Replace aarch64 with arm in cross-i686-tci build Richard Henderson
2025-02-08 20:57 ` [PULL 6/9] configure: Define TARGET_LONG_BITS in configs/targets/*.mak Richard Henderson
2025-02-08 20:57 ` [PULL 7/9] target/*: Remove TARGET_LONG_BITS from cpu-param.h Richard Henderson
2025-02-08 20:57 ` [PULL 8/9] meson: Disallow 64-bit on 32-bit emulation Richard Henderson
2025-04-11 13:42   ` Daniel P. Berrangé
2025-04-11 15:05     ` Philippe Mathieu-Daudé
2025-04-11 15:08       ` Daniel P. Berrangé
2025-04-11 18:18         ` Stefan Hajnoczi
2025-02-08 20:57 ` [PULL 9/9] meson: Deprecate 32-bit host support Richard Henderson
2025-02-10 18:21 ` [PULL 0/9] meson: Disallow 64-bit on 32-bit emulation Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeaf0f19-0f14-4a02-9c51-09521e7c75e1@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=anthony@xenproject.org \
    --cc=berrange@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=edgar.iglesias@gmail.com \
    --cc=paul@xen.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sstabellini@kernel.org \
    --cc=thuth@redhat.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).