From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Cédric Le Goater" <clg@kaod.org>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Joel Stanley" <joel@jms.id.au>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>
Subject: Re: [PATCH for-8.2 2/4] hw/rtc/twl92230: Use int64_t for sec_offset and alm_sec
Date: Fri, 21 Jul 2023 11:09:52 +0200 [thread overview]
Message-ID: <aeb9374e-014c-f9ae-43d8-25579c3090e8@linaro.org> (raw)
In-Reply-To: <20230720155902.1590362-3-peter.maydell@linaro.org>
On 20/7/23 17:59, Peter Maydell wrote:
> In the twl92230 device, use int64_t for the two state fields
> sec_offset and alm_sec, because we set these to values that
> are either time_t or differences between two time_t values.
>
> These fields aren't saved in vmstate anywhere, so we can
> safely widen them.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I have a suspicion that really these fields *should* be
> being migrated, but this device is only used in the n800
> and n810 boards, so I'm not going to investigate how broken
> migration/vmsave is there...
> ---
> hw/rtc/twl92230.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-07-21 9:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 15:58 [PATCH for-8.2 0/4] rtc devices: Avoid putting time_t in 32-bit variables Peter Maydell
2023-07-20 15:58 ` [PATCH for-8.2 1/4] hw/rtc/m48t59: Use 64-bit arithmetic in set_alarm() Peter Maydell
2023-07-21 9:03 ` Philippe Mathieu-Daudé
2023-07-21 9:09 ` Philippe Mathieu-Daudé
2023-07-21 9:42 ` Peter Maydell
2023-07-20 15:59 ` [PATCH for-8.2 2/4] hw/rtc/twl92230: Use int64_t for sec_offset and alm_sec Peter Maydell
2023-07-21 9:09 ` Philippe Mathieu-Daudé [this message]
2023-07-20 15:59 ` [PATCH for-8.2 3/4] hw/rtc/aspeed_rtc: Use 64-bit offset for holding time_t difference Peter Maydell
2023-07-20 16:42 ` Cédric Le Goater
2023-07-20 16:45 ` Peter Maydell
2023-07-20 16:58 ` Cédric Le Goater
2023-07-20 15:59 ` [PATCH for-8.2 4/4] rtc: Use time_t for passing and returning time offsets Peter Maydell
2023-07-21 9:18 ` Philippe Mathieu-Daudé
2023-07-21 9:03 ` [PATCH for-8.2 0/4] rtc devices: Avoid putting time_t in 32-bit variables Philippe Mathieu-Daudé
2023-07-21 9:45 ` Peter Maydell
2023-07-24 5:15 ` Markus Armbruster
2023-07-21 9:16 ` Philippe Mathieu-Daudé
2023-07-21 9:46 ` Peter Maydell
2023-07-24 14:01 ` Philippe Mathieu-Daudé
2023-08-29 15:50 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeb9374e-014c-f9ae-43d8-25579c3090e8@linaro.org \
--to=philmd@linaro.org \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=hpoussin@reactos.org \
--cc=joel@jms.id.au \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).