From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ixjeu-0005fF-TU for qemu-devel@nongnu.org; Thu, 29 Nov 2007 08:42:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ixjeq-0005dx-Ri for qemu-devel@nongnu.org; Thu, 29 Nov 2007 08:42:28 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ixjeq-0005du-MR for qemu-devel@nongnu.org; Thu, 29 Nov 2007 08:42:24 -0500 Received: from rn-out-0910.google.com ([64.233.170.190] helo=rn-out-0102.google.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ixjeq-00075R-98 for qemu-devel@nongnu.org; Thu, 29 Nov 2007 08:42:24 -0500 Received: by rn-out-0102.google.com with SMTP id i19so1597373rng for ; Thu, 29 Nov 2007 05:42:23 -0800 (PST) Message-ID: Date: Thu, 29 Nov 2007 22:42:23 +0900 From: "Magnus Damm" MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_766_4125239.1196343743392" Subject: [Qemu-devel] [PATCH] execve syscall fix Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ------=_Part_766_4125239.1196343743392 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi everyone, The execve syscall currently fails on sh4 with -EFAULT. I tracked it down to what looks like a generic problem. This patch makes sure that the two variables "guest_argp" and "guest_envp" are set to "arg2" and "arg3" instead of the old NULL values from previous get_user_ual() calls. Execve now works as expected on sh4 with this fix. Please apply. / magnus ------=_Part_766_4125239.1196343743392 Content-Type: application/octet-stream; name=qemu-cvs-20071129-execve-fix.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_f9lc1xhg0 Content-Disposition: attachment; filename=qemu-cvs-20071129-execve-fix.patch LS0tIDAwMDEvbGludXgtdXNlci9zeXNjYWxsLmMKKysrIHdvcmsvbGludXgtdXNlci9zeXNjYWxs LmMJMjAwNy0xMS0yOSAyMjozMjo0NS4wMDAwMDAwMDAgKzA5MDAKQEAgLTMyMDYsNiArMzIwNiw3 IEBAIGFiaV9sb25nIGRvX3N5c2NhbGwodm9pZCAqY3B1X2VudiwgaW50IG4KICAgICAgICAgICAg IGFyZ3AgPSBhbGxvY2EoKGFyZ2MgKyAxKSAqIHNpemVvZih2b2lkICopKTsKICAgICAgICAgICAg IGVudnAgPSBhbGxvY2EoKGVudmMgKyAxKSAqIHNpemVvZih2b2lkICopKTsKIAorICAgICAgICAg ICAgZ3Vlc3RfYXJncCA9IGFyZzI7CiAgICAgICAgICAgICBmb3IgKGdwID0gZ3Vlc3RfYXJncCwg cSA9IGFyZ3A7IDsKICAgICAgICAgICAgICAgICAgIGdwICs9IHNpemVvZihhYmlfdWxvbmcpLCBx KyspIHsKICAgICAgICAgICAgICAgICBpZiAoZ2V0X3VzZXJfdWFsKGFkZHIsIGdwKSkKQEAgLTMy MTcsNiArMzIxOCw3IEBAIGFiaV9sb25nIGRvX3N5c2NhbGwodm9pZCAqY3B1X2VudiwgaW50IG4K ICAgICAgICAgICAgIH0KICAgICAgICAgICAgICpxID0gTlVMTDsKIAorICAgICAgICAgICAgZ3Vl c3RfZW52cCA9IGFyZzM7CiAgICAgICAgICAgICBmb3IgKGdwID0gZ3Vlc3RfZW52cCwgcSA9IGVu dnA7IDsKICAgICAgICAgICAgICAgICAgIGdwICs9IHNpemVvZihhYmlfdWxvbmcpLCBxKyspIHsK ICAgICAgICAgICAgICAgICBpZiAoZ2V0X3VzZXJfdWFsKGFkZHIsIGdwKSkK ------=_Part_766_4125239.1196343743392--