qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Magnus Damm" <magnus.damm@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t
Date: Fri, 30 Nov 2007 14:36:32 +0900	[thread overview]
Message-ID: <aec7e5c30711292136h2132ae81k8799694270b6659e@mail.gmail.com> (raw)
In-Reply-To: <20071118211837.GA15962@tapir>

On Nov 19, 2007 6:18 AM, Carlo Marcelo Arenas Belon
<carenas@sajinet.com.pe> wrote:
> The following patch changes the formatting string from %08x to TARGET_FMT_plx
> to accommodate for compilation in 64bit hosts and that manifests with the
> following warning :
>
>   qemu/hw/sh7750.c: In function `error_access':
>   qemu/hw/sh7750.c:186: warning: unsigned int format, different type arg (arg 5)
>   qemu/hw/sh7750.c: In function `ignore_access':
>   qemu/hw/sh7750.c:192: warning: unsigned int format, different type arg (arg 5)

This patch works fine on 32 bit x86 hosts. Please apply.

> Index: sh7750.c
> ===================================================================
> RCS file: /sources/qemu/qemu/hw/sh7750.c,v
> retrieving revision 1.11
> diff -u -r1.11 sh7750.c
> --- sh7750.c    17 Nov 2007 17:14:48 -0000      1.11
> +++ sh7750.c    18 Nov 2007 21:08:37 -0000

Could you please create the diff from the top level directory next
time? That way it can be applied with patch -p0 or -p1 directly in the
top level directory which makes patch handling much easier. Thanks!

/ magnus

  reply	other threads:[~2007-11-30  5:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-11 15:49 [Qemu-devel] [PATCH] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t Carlo Marcelo Arenas Belon
2007-11-18 21:18 ` [Qemu-devel] [PATCH] [RESEND] " Carlo Marcelo Arenas Belon
2007-11-30  5:36   ` Magnus Damm [this message]
2007-11-30 15:21     ` Carlo Marcelo Arenas Belon
2007-11-30 15:37       ` Blue Swirl
2007-11-30 16:11         ` Carlo Marcelo Arenas Belon
2007-11-30 16:50         ` Paul Brook
2007-11-30 17:16           ` Blue Swirl
2007-11-30 17:42             ` Paul Brook
2007-11-30 18:45               ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aec7e5c30711292136h2132ae81k8799694270b6659e@mail.gmail.com \
    --to=magnus.damm@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).