From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IxyYG-0000om-0g
	for qemu-devel@nongnu.org; Fri, 30 Nov 2007 00:36:36 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IxyYE-0000oT-Ap
	for qemu-devel@nongnu.org; Fri, 30 Nov 2007 00:36:35 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IxyYE-0000oQ-13
	for qemu-devel@nongnu.org; Fri, 30 Nov 2007 00:36:34 -0500
Received: from rn-out-0910.google.com ([64.233.170.187]
	helo=rn-out-0102.google.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <magnus.damm@gmail.com>) id 1IxyYD-0006Nr-Li
	for qemu-devel@nongnu.org; Fri, 30 Nov 2007 00:36:33 -0500
Received: by rn-out-0102.google.com with SMTP id i19so2278435rng
	for <qemu-devel@nongnu.org>; Thu, 29 Nov 2007 21:36:33 -0800 (PST)
Message-ID: <aec7e5c30711292136h2132ae81k8799694270b6659e@mail.gmail.com>
Date: Fri, 30 Nov 2007 14:36:32 +0900
From: "Magnus Damm" <magnus.damm@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to
	printf target_phys_addr_t
In-Reply-To: <20071118211837.GA15962@tapir>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20071111154922.GE25322@tapir> <20071118211837.GA15962@tapir>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Nov 19, 2007 6:18 AM, Carlo Marcelo Arenas Belon
<carenas@sajinet.com.pe> wrote:
> The following patch changes the formatting string from %08x to TARGET_FMT_plx
> to accommodate for compilation in 64bit hosts and that manifests with the
> following warning :
>
>   qemu/hw/sh7750.c: In function `error_access':
>   qemu/hw/sh7750.c:186: warning: unsigned int format, different type arg (arg 5)
>   qemu/hw/sh7750.c: In function `ignore_access':
>   qemu/hw/sh7750.c:192: warning: unsigned int format, different type arg (arg 5)

This patch works fine on 32 bit x86 hosts. Please apply.

> Index: sh7750.c
> ===================================================================
> RCS file: /sources/qemu/qemu/hw/sh7750.c,v
> retrieving revision 1.11
> diff -u -r1.11 sh7750.c
> --- sh7750.c    17 Nov 2007 17:14:48 -0000      1.11
> +++ sh7750.c    18 Nov 2007 21:08:37 -0000

Could you please create the diff from the top level directory next
time? That way it can be applied with patch -p0 or -p1 directly in the
top level directory which makes patch handling much easier. Thanks!

/ magnus