qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Yonggang Luo <luoyonggang@gmail.com>, qemu-devel@nongnu.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2
Date: Sat, 5 Sep 2020 10:48:44 +0200	[thread overview]
Message-ID: <aed3143c-5bf5-3b40-2c7c-1db2ac43f4c9@redhat.com> (raw)
In-Reply-To: <20200905063813.1875-1-luoyonggang@gmail.com>

On 05/09/2020 08.38, Yonggang Luo wrote:
> ../tests/test-vmstate.c: In function 'int_cmp':
> ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you mean 'uInt'?
>   884 |     uint ua = GPOINTER_TO_UINT(a);
>       |     ^~~~
>       |     uInt
> ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you mean 'uInt'?
>   885 |     uint ub = GPOINTER_TO_UINT(b);
>       |     ^~~~
>       |     uInt
> make: *** [Makefile.ninja:5461:tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
> 
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>  tests/test-vmstate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f7b3868881..f8de709a0b 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
>  /* ID comparison function */
>  static gint int_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
>  {
> -    uint ua = GPOINTER_TO_UINT(a);
> -    uint ub = GPOINTER_TO_UINT(b);
> +    guint ua = GPOINTER_TO_UINT(a);
> +    guint ub = GPOINTER_TO_UINT(b);
>      return (ua > ub) - (ua < ub);
>  }

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2020-09-05  8:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05  6:38 [PATCH] tests: fixes test-vmstate.c compile error on msys2 Yonggang Luo
2020-09-05  8:48 ` Thomas Huth [this message]
2020-09-05 16:16   ` 罗勇刚(Yonggang Luo)
2020-09-05 16:32     ` Thomas Huth
2020-09-05 21:33 ` Philippe Mathieu-Daudé
2020-09-07  2:57 ` 罗勇刚(Yonggang Luo)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aed3143c-5bf5-3b40-2c7c-1db2ac43f4c9@redhat.com \
    --to=thuth@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=luoyonggang@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).