From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:49847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpS6G-0005Xg-QQ for qemu-devel@nongnu.org; Fri, 01 Feb 2019 01:14:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpS6G-00039q-10 for qemu-devel@nongnu.org; Fri, 01 Feb 2019 01:14:52 -0500 References: <1548956828-10210-1-git-send-email-thuth@redhat.com> <20190131185621.28815291.cohuck@redhat.com> <538ee62b-293d-f053-4bd2-76bf166388e1@redhat.com> From: Thomas Huth Message-ID: Date: Fri, 1 Feb 2019 07:14:46 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Cornelia Huck Cc: Collin Walling , qemu-devel@nongnu.org, qemu-s390x@nongnu.org On 2019-01-31 19:08, Paolo Bonzini wrote: > On 31/01/19 19:00, Thomas Huth wrote: >>>> (and the prototypes in the header) anymore, so if you try to compile s390x >>>> without CONFIG_PCI, the build currently fails. >>>> >>> Fixes: 468a93898a97 ("s390x/pci: pass the retaddr to all PCI instructions") >>> >>>> Signed-off-by: Thomas Huth >>>> --- >>>> hw/s390x/s390-pci-stub.c | 16 +++++++++------- >>>> 1 file changed, 9 insertions(+), 7 deletions(-) >>> This file seems to be in danger of bitrot. Do you think it'll be easier >>> to test rarely used configs like that after we switch to Kconfig? >> I hope so, yes. There will be a new --without-default-devices options >> for "configure" (which matches "make allnoconfig" from the kernel) - if >> we do it right in the Kconfig file for s390x, it should be possible to >> catch this problem with that option. > > Yes, it will be in .travis.yml too. > > Right now there is a "select PCI" in the hw/s390x/Kconfig file, but > probably it's best to add a config S390_ZPCI with "default y if > S390_CCW_VIRTIO" and "select PCI" in it. Not a blocker, but I can > integrate it if you send me a fixup patch. Yes, that's what I had in mind, too. I'll send a fixup patch... Thomas