From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD55C433E0 for ; Tue, 2 Jun 2020 16:08:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A773B206E2 for ; Tue, 2 Jun 2020 16:08:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="a5D1buW9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A773B206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jg9TA-0004rC-RS for qemu-devel@archiver.kernel.org; Tue, 02 Jun 2020 12:08:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jg9SU-0004F4-C0 for qemu-devel@nongnu.org; Tue, 02 Jun 2020 12:08:10 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:24743 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jg9ST-0003QJ-JM for qemu-devel@nongnu.org; Tue, 02 Jun 2020 12:08:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591114088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LgtZrgshUUydCGmUAURdfmKiD+67FE8HSKCbU4UjSL4=; b=a5D1buW99SgV8BPBEZSLbyzs2LTg2XVNQqkiUdKn4n9eINO6+REYobVoaBDdwlue6VL+Y5 RjJY4rbfFiyDP9ShjkFQMFdKqo+nal7GIUv9MOPiyjbh6EtTSiO0Y3r8/Czw2vhkD7UUCR myHxFBIgx99zlHhDRf5Edk58XhY/dYg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-24-8BDLaBw9Nbue8ANzqH52Lw-1; Tue, 02 Jun 2020 12:08:03 -0400 X-MC-Unique: 8BDLaBw9Nbue8ANzqH52Lw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 945947BAC; Tue, 2 Jun 2020 16:07:59 +0000 (UTC) Received: from [10.3.113.22] (ovpn-113-22.phx2.redhat.com [10.3.113.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 154216062D; Tue, 2 Jun 2020 16:07:59 +0000 (UTC) Subject: Re: [PATCH v3 1/6] iotests: Add extension names to qcow2.py dump From: Eric Blake To: Andrey Shinkevich , qemu-block@nongnu.org References: <1591019293-211155-1-git-send-email-andrey.shinkevich@virtuozzo.com> <1591019293-211155-2-git-send-email-andrey.shinkevich@virtuozzo.com> Organization: Red Hat, Inc. Message-ID: Date: Tue, 2 Jun 2020 11:07:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/02 03:23:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, den@openvz.org, vsementsov@virtuozzo.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/2/20 11:05 AM, Eric Blake wrote: [I hit send too soon...] >> +++ b/tests/qemu-iotests/qcow2.py >> @@ -6,19 +6,36 @@ import string >>   class QcowHeaderExtension: >> +    QCOW2_EXT_MAGIC_BACKING_FORMAT = 0xE2792ACA >> +    QCOW2_EXT_MAGIC_FEATURE_TABLE = 0x6803f857 > > Why the inconsistency between capitalization in these constants? At least it matches the inconsistency in docs/interop/qcow2.txt; a patch to fix that wouldn't hurt. > > Reviewed-by: Eric Blake > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org