From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE757C433E0 for ; Mon, 4 Jan 2021 20:51:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38F06216C4 for ; Mon, 4 Jan 2021 20:51:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38F06216C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwWp9-0005t2-RZ for qemu-devel@archiver.kernel.org; Mon, 04 Jan 2021 15:51:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwWoN-0005Ix-9e for qemu-devel@nongnu.org; Mon, 04 Jan 2021 15:50:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:33610) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kwWoL-0005zW-6E for qemu-devel@nongnu.org; Mon, 04 Jan 2021 15:50:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609793438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JygAV7c5qWb+7iyvfhbKRauIqHn/n1Tv8tzTH40R+v0=; b=agzwx5QwVQL4ghv7uhW09FjwT31NnIWXXgV1X8zGmKtyzmhwZGRee11CqohgGjPph29RQH h4HP7EQF2uhfjOaX8yiUpyhcCsWkxyWnc0dQxj+jcKGHoaI9kTQrKMJzfSY0AftTjGdXqt hJ/Xo/7SAS5mja7SZgoQbPGLnQ0KJC8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-532-ZY3T7UlaOAeKIHDli4AKQw-1; Mon, 04 Jan 2021 15:50:35 -0500 X-MC-Unique: ZY3T7UlaOAeKIHDli4AKQw-1 Received: by mail-wm1-f70.google.com with SMTP id k67so240594wmk.5 for ; Mon, 04 Jan 2021 12:50:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JygAV7c5qWb+7iyvfhbKRauIqHn/n1Tv8tzTH40R+v0=; b=JUEmDYaFGi4Z7ol0H2Rjagi8LpdYcKVOGiHcUG24N79v+TyhXs5kSs70STNiDXnaWb LH1CWtsMhbCdXzAlurrEwg8JHu0lTGSwVFfPEWx3eJT2nZCgBH1qsBLlvxpSGiKaunlG rNV+4cPKnaQpP9OEKPqpo38a4AI3G4W/0FtHnpoOdxCJWyawl5QBAGP0phwUeTU4yy1V iR4WKpRFw8WEaMvsV2oAQeVBjIe6mZD6yqnI/T5uIr+5Y/kpwKySUKUsV07ioU3zGfqF UEwZIcgBpzY9NHMDAbzpfonwqWGTnGjDhysGXFhJFEuonYNfNlEgDoLnJdLy0j0nuEhA DEoQ== X-Gm-Message-State: AOAM532+VXvUrGXMKygXaSYK+HuJWBoiGH0jXcttJxe8/lRIT/jTOW05 eYaGgw8ZjUlSfznloHjXvq+5a7GODjsL7e5CcF5CbtcyPq818PH+xC2HPlVgEzzydWbv1Qyuzyo woE4PhPw3U8BSrVI= X-Received: by 2002:a7b:c319:: with SMTP id k25mr591979wmj.142.1609793434429; Mon, 04 Jan 2021 12:50:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYcuksqo7g2BIL4S+xfuT5/3J6fM3BmMHkxXvWYJpJv25HFxdrJ2kfreki3wjM2s+HrXGnMw== X-Received: by 2002:a7b:c319:: with SMTP id k25mr591960wmj.142.1609793434180; Mon, 04 Jan 2021 12:50:34 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id e17sm91893809wrw.84.2021.01.04.12.50.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jan 2021 12:50:33 -0800 (PST) Subject: Re: [PATCH] meson: Propagate gnutls dependency To: Roman Bolshakov References: <20210102125213.41279-1-r.bolshakov@yadro.com> From: Paolo Bonzini Message-ID: Date: Mon, 4 Jan 2021 21:50:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.243, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , "open list:Block layer core" , QEMU Developers , Max Reitz , Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 04/01/21 18:24, Roman Bolshakov wrote: > Hi Paolo, > > I'm sorry I didn't reply earlier. As I showed in an example to Peter > (https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg00085.html): > https://github.com/mesonbuild/meson/commit/ff5dc65ef841857dd306694dff1fb1cd2bf801e4 > > The approach doesn't propogate dependencies of crypto beyond libcrypto. > i.e. if you specify crypto somewhere else as depedency, it won't pull > CFLAGS needed for gnutls. Hi Roman, After writing the meson patch in fact I noticed that get_dependencies() is used only for linker flags. I got a very quick reply from the Meson maintainer (https://github.com/mesonbuild/meson/pull/8151): The fact that header flags are not passed transitively but libraries are (in some cases) is intentional. Otherwise compiler flag counts explode in deep hierarchies. Because of this include paths must be exported manually, typically by adding the appropriate bits to a declare_dependency. Libs are a bit stupid, because you need to add direct dependencies if, for example, you link to a static library. Does it work if you do: crypto_ss.add(authz, qom) libcrypto = static_library('crypto', crypto_ss.sources() + genh, dependencies: crypto_ss.dependencies(), ...) crypto = declare_dependency(link_whole: libcrypto, dependencies: crypto_ss.dependencies()) ? If so, that is also a good option. If not, I will try to extend the test case to pitch the Meson change. Paolo