From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-arm@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Ryan Chen" <ryan_chen@aspeedtech.com>,
"Corey Minyard" <minyard@acm.org>,
"Cameron Esfahani via" <qemu-devel@nongnu.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Joel Stanley" <joel@jms.id.au>
Subject: Re: [PATCH 2/4] arm: ast2600: Fix iBT IRQ ID
Date: Mon, 01 Mar 2021 09:38:50 +1030 [thread overview]
Message-ID: <af0b09f9-daff-463e-a887-387ff6d9a132@www.fastmail.com> (raw)
In-Reply-To: <c74d23df-d90b-93e8-fe40-7de905b5af3e@amsat.org>
On Fri, 26 Feb 2021, at 19:28, Philippe Mathieu-Daudé wrote:
> On 2/26/21 7:57 AM, Andrew Jeffery wrote:
> > The AST2600 allocates individual GIC IRQ lines for the LPC sub-devices.
> > This is a contrast to the AST2400 and AST2500 which use one shared VIC
> > IRQ line for the LPC sub-devices. Switch the iBT device to use the
> > GIC IRQ ID documented in the datasheet.
>
> [*]
>
> >
> > While we're here, set the number of IRQs to the allocated number of IRQs
> > in the datasheet.
>
> Please do one change per patch. This would be the first change,
> and [*] is the second.
Given that I had to change the current value to support the iBT device
I figured it would be fine in the same patch, but sure, I can split
this out in v2.
Andrew
next prev parent reply other threads:[~2021-02-28 23:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 6:57 [PATCH 0/4] aspeed: LPC peripheral controller devices Andrew Jeffery
2021-02-26 6:57 ` [PATCH 1/4] arm: ast2600: Force a multiple of 32 of IRQs for the GIC Andrew Jeffery
2021-02-26 8:56 ` Philippe Mathieu-Daudé
2021-02-28 23:07 ` Andrew Jeffery
2021-03-01 0:23 ` Andrew Jeffery
2021-02-26 6:57 ` [PATCH 2/4] arm: ast2600: Fix iBT IRQ ID Andrew Jeffery
2021-02-26 8:58 ` Philippe Mathieu-Daudé
2021-02-28 23:08 ` Andrew Jeffery [this message]
2021-02-26 6:57 ` [PATCH 3/4] hw/misc: Add a basic Aspeed LPC controller model Andrew Jeffery
2021-02-26 6:57 ` [PATCH 4/4] hw/misc: Model KCS devices in the Aspeed LPC controller Andrew Jeffery
2021-02-26 9:51 ` Cédric Le Goater
2021-02-28 23:14 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af0b09f9-daff-463e-a887-387ff6d9a132@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=f4bug@amsat.org \
--cc=joel@jms.id.au \
--cc=minyard@acm.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).