From: Thomas Huth <thuth@redhat.com>
To: Fabiano Rosas <farosas@suse.de>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 2/3] arm/Kconfig: Keep Kconfig default entries in default.mak as documentation
Date: Tue, 23 May 2023 20:24:23 +0200 [thread overview]
Message-ID: <af132528-fe90-5ac1-6a78-fadc06eb8e75@redhat.com> (raw)
In-Reply-To: <20230523180525.29994-3-farosas@suse.de>
On 23/05/2023 20.05, Fabiano Rosas wrote:
> When we moved the arm default CONFIGs into Kconfig and removed them
> from default.mak, we made it harder to identify which CONFIGs are
> selected by default in case users want to disable them.
>
> Bring back the default entries into default.mak, but keep them
> commented out. This way users can keep their workflows of editing
> default.mak to remove build options without needing to search through
> Kconfig.
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> configs/devices/aarch64-softmmu/default.mak | 6 ++++
> configs/devices/arm-softmmu/default.mak | 40 +++++++++++++++++++++
> 2 files changed, 46 insertions(+)
Thanks for the update!
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-05-23 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 18:05 [PATCH 0/3] arm/Kconfig: Some convenience changes Fabiano Rosas
2023-05-23 18:05 ` [PATCH 1/3] target/arm: Explain why we need to select ARM_V7M Fabiano Rosas
2023-05-24 6:25 ` Philippe Mathieu-Daudé
2023-05-23 18:05 ` [PATCH 2/3] arm/Kconfig: Keep Kconfig default entries in default.mak as documentation Fabiano Rosas
2023-05-23 18:24 ` Thomas Huth [this message]
2023-05-23 18:05 ` [PATCH 3/3] arm/Kconfig: Make TCG dependence explicit Fabiano Rosas
2023-05-23 18:28 ` Thomas Huth
2023-05-24 6:25 ` Philippe Mathieu-Daudé
2023-05-30 12:07 ` [PATCH 0/3] arm/Kconfig: Some convenience changes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af132528-fe90-5ac1-6a78-fadc06eb8e75@redhat.com \
--to=thuth@redhat.com \
--cc=farosas@suse.de \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).