From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bS583-0004tb-0j for qemu-devel@nongnu.org; Tue, 26 Jul 2016 12:22:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bS581-0002yA-Sn for qemu-devel@nongnu.org; Tue, 26 Jul 2016 12:22:46 -0400 References: <1469520941-16283-1-git-send-email-xiecl.fnst@cn.fujitsu.com> <1469520941-16283-12-git-send-email-xiecl.fnst@cn.fujitsu.com> From: Max Reitz Message-ID: Date: Tue, 26 Jul 2016 18:22:34 +0200 MIME-Version: 1.0 In-Reply-To: <1469520941-16283-12-git-send-email-xiecl.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MQ5vGxDwxWcXilB1hs24SI9CT6N3AXRwg" Subject: Re: [Qemu-devel] [PATCH v23 11/12] support replication driver in blockdev-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Changlong Xie , qemu devel , qemu block , Stefan Hajnoczi , Fam Zheng , Kevin Wolf , Jeff Cody Cc: Paolo Bonzini , John Snow , Eric Blake , Markus Armbruster , "Dr. David Alan Gilbert" , Dong Eddie , Jiang Yunhong , zhanghailiang , Gonglei , Wen Congyang , Wang Weiwei This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MQ5vGxDwxWcXilB1hs24SI9CT6N3AXRwg From: Max Reitz To: Changlong Xie , qemu devel , qemu block , Stefan Hajnoczi , Fam Zheng , Kevin Wolf , Jeff Cody Cc: Paolo Bonzini , John Snow , Eric Blake , Markus Armbruster , "Dr. David Alan Gilbert" , Dong Eddie , Jiang Yunhong , zhanghailiang , Gonglei , Wen Congyang , Wang Weiwei Message-ID: Subject: Re: [PATCH v23 11/12] support replication driver in blockdev-add References: <1469520941-16283-1-git-send-email-xiecl.fnst@cn.fujitsu.com> <1469520941-16283-12-git-send-email-xiecl.fnst@cn.fujitsu.com> In-Reply-To: <1469520941-16283-12-git-send-email-xiecl.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 26.07.2016 10:15, Changlong Xie wrote: > From: Wen Congyang >=20 > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > Signed-off-by: Wang WeiWei > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Reviewed-by: Eric Blake > --- > qapi/block-core.json | 22 ++++++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) >=20 > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 7258a87..48aa112 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -248,6 +248,7 @@ > # 2.3: 'host_floppy' deprecated > # 2.5: 'host_floppy' dropped > # 2.6: 'luks' added > +# 2.8: 'replication' added > # > # @backing_file: #optional the name of the backing file (for copy-on-w= rite) > # > @@ -1696,8 +1697,8 @@ > 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop', > 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom', > 'host_device', 'http', 'https', 'luks', 'null-aio', 'null-= co', > - 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tft= p', > - 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] } > + 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'rep= lication', > + 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] } > =20 > ## > # @BlockdevOptionsFile > @@ -2160,6 +2161,22 @@ > { 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] } > =20 > ## > +# @BlockdevOptionsReplication > +# > +# Driver specific block device options for replication > +# > +# @mode: the replication mode > +# > +# @top-id: the id to protect replication model chain It's hard for me to understand this sentence without reading the code and thus knowing what this ID is used for. I'd use the following instead:= @top-id: In secondary mode, node name or device ID of the root node who owns the replication node chain. Ignored in primary mode. Also, since this parameter is only necessary in secondary mode and completely ignored in primary mode, I would probably make it an optional parameter. Max > +# > +# Since: 2.8 > +## > +{ 'struct': 'BlockdevOptionsReplication', > + 'base': 'BlockdevOptionsGenericFormat', > + 'data': { 'mode': 'ReplicationMode', > + 'top-id': 'str' } } > + > +## > # @BlockdevOptions > # > # Options for creating a block device. Many options are available for= all > @@ -2224,6 +2241,7 @@ > 'quorum': 'BlockdevOptionsQuorum', > 'raw': 'BlockdevOptionsGenericFormat', > # TODO rbd: Wait for structured options > + 'replication':'BlockdevOptionsReplication', > # TODO sheepdog: Wait for structured options > # TODO ssh: Should take InetSocketAddress for 'host'? > 'tftp': 'BlockdevOptionsFile', >=20 --MQ5vGxDwxWcXilB1hs24SI9CT6N3AXRwg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXl45KEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6DisrRNh CAChGhGoMWlHoJLSG1w5Xn08i0c+Vx66YotybSDivTHUFuohUK3A/ksQ6Q+sZaG3 HHI+QtfBUgFo4gkpLK7o/VvL4eiQWAI4T6slYAcbP5vcablgWizJoc2WOjIB3ySz Xv9gfoU1A4xHhg76RxdHmJHyiTVdebKSRgQgBout9GRFkPkm69fELZcY2D4jpvbN rEhfoP4bP1/1wjPCuutAvsfPUrECbpuO1REJozAVpZpRYsFCEOX+8gePoL2EwWHj 06btBzBtGL7G2i88dPwWQ6I1uCGNdSSfT57WrBr/r1GuRkwuBTOdlrxz+RCM+Ctd Itkl+bUwoFWfA9kQk331IcQ3 =KF4b -----END PGP SIGNATURE----- --MQ5vGxDwxWcXilB1hs24SI9CT6N3AXRwg--