From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Paolo Bonzini <pbonzini@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] trace: Forbid trailing newline in event format
Date: Fri, 13 Sep 2019 16:10:58 -0400 [thread overview]
Message-ID: <af4ef81c-5a4d-847d-37bd-3696a3b77c68@redhat.com> (raw)
In-Reply-To: <20190913105205.7581-1-philmd@redhat.com>
On 9/13/19 6:52 AM, Philippe Mathieu-Daudé wrote:
> Hi Stefan,
>
> I'v been confused by trailing newline in trace reports,
> so this series aims to fix this, by cleaning current
> formats and add a check to catch new one introduced.
>
> Regards,
>
> Phil.
>
> Philippe Mathieu-Daudé (2):
> trace: Remove trailing newline in events
> trace: Forbid event format ending with newline character
>
> docs/devel/tracing.txt | 2 ++
> hw/misc/trace-events | 10 +++++-----
> hw/scsi/trace-events | 2 +-
> hw/sd/trace-events | 2 +-
> nbd/trace-events | 4 ++--
> net/trace-events | 6 +++---
> scripts/tracetool/__init__.py | 3 +++
> 7 files changed, 17 insertions(+), 12 deletions(-)
>
Never mind my bikeshedding.
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2019-09-13 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 10:52 [Qemu-devel] [PATCH 0/2] trace: Forbid trailing newline in event format Philippe Mathieu-Daudé
2019-09-13 10:52 ` [Qemu-devel] [PATCH 1/2] trace: Remove trailing newline in events Philippe Mathieu-Daudé
2019-09-13 10:52 ` [Qemu-devel] [PATCH 2/2] trace: Forbid event format ending with newline character Philippe Mathieu-Daudé
2019-09-13 20:01 ` [Qemu-devel] [Qemu-block] " John Snow
2019-09-13 21:00 ` Philippe Mathieu-Daudé
2019-09-13 21:08 ` John Snow
2019-09-13 20:10 ` John Snow [this message]
2019-09-16 8:07 ` [Qemu-devel] [Qemu-block] [PATCH 0/2] trace: Forbid trailing newline in event format Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af4ef81c-5a4d-847d-37bd-3696a3b77c68@redhat.com \
--to=jsnow@redhat.com \
--cc=fam@euphon.net \
--cc=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).