qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Thomas Huth <thuth@redhat.com>,
	 qemu-arm@nongnu.org
Subject: Re: [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes
Date: Fri, 20 Oct 2023 14:31:43 -0700	[thread overview]
Message-ID: <af5539ab-ecb1-483f-b96e-1604239a4e6e@linaro.org> (raw)
In-Reply-To: <20231020130331.50048-1-philmd@linaro.org>

On 10/20/23 06:03, Philippe Mathieu-Daudé wrote:
> Missing review: 6-9
> 
> Hi,
> 
> Extracted from a bigger series which enforce QDev state machine
> (qdev instance must be realized before external API is used on
> it).
> 
> While here, pxa2xx i2c/intc devices received some qdev fondness.
> 
> Since v3:
> - Added Thomas R-b tags
> 
> Since v2:
> - Fixed i2c_init_bus() call in pxa2xx_i2c_init() (new patch)
> 
> Philippe Mathieu-Daudé (9):
>    hw/sd/pxa2xx: Realize sysbus device before accessing it
>    hw/sd/pxa2xx: Do not open-code sysbus_create_simple()
>    hw/pcmcia/pxa2xx: Realize sysbus device before accessing it
>    hw/pcmcia/pxa2xx: Do not open-code sysbus_create_simple()
>    hw/pcmcia/pxa2xx: Inline pxa2xx_pcmcia_init()
>    hw/intc/pxa2xx: Convert to Resettable interface
>    hw/intc/pxa2xx: Pass CPU reference using QOM link property
>    hw/intc/pxa2xx: Factor pxa2xx_pic_realize() out of pxa2xx_pic_init()
>    hw/arm/pxa2xx: Realize PXA2XX_I2C device before accessing it

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


  parent reply	other threads:[~2023-10-22  1:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20 13:03 [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes Philippe Mathieu-Daudé
2023-10-20 13:03 ` [PATCH v3 1/9] hw/sd/pxa2xx: Realize sysbus device before accessing it Philippe Mathieu-Daudé
2023-10-20 13:03 ` [PATCH v3 2/9] hw/sd/pxa2xx: Do not open-code sysbus_create_simple() Philippe Mathieu-Daudé
2023-10-20 13:03 ` [PATCH v3 3/9] hw/pcmcia/pxa2xx: Realize sysbus device before accessing it Philippe Mathieu-Daudé
2023-10-20 13:03 ` [PATCH v3 4/9] hw/pcmcia/pxa2xx: Do not open-code sysbus_create_simple() Philippe Mathieu-Daudé
2023-10-20 13:03 ` [PATCH v3 5/9] hw/pcmcia/pxa2xx: Inline pxa2xx_pcmcia_init() Philippe Mathieu-Daudé
2023-10-20 13:03 ` [PATCH v3 6/9] hw/intc/pxa2xx: Convert to Resettable interface Philippe Mathieu-Daudé
2023-10-20 13:03 ` [PATCH v3 7/9] hw/intc/pxa2xx: Pass CPU reference using QOM link property Philippe Mathieu-Daudé
2023-10-23  6:45   ` Thomas Huth
2023-10-20 13:03 ` [PATCH v3 8/9] hw/intc/pxa2xx: Factor pxa2xx_pic_realize() out of pxa2xx_pic_init() Philippe Mathieu-Daudé
2023-10-23  6:46   ` Thomas Huth
2023-10-20 13:03 ` [PATCH v3 9/9] hw/arm/pxa2xx: Realize PXA2XX_I2C device before accessing it Philippe Mathieu-Daudé
2023-10-23  6:47   ` Thomas Huth
2023-10-20 21:31 ` Richard Henderson [this message]
2023-10-27 11:49 ` [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af5539ab-ecb1-483f-b96e-1604239a4e6e@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).