From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: Re: [PATCH for-5.2 1/4] ivshmem-test: do not use short-form boolean option
Date: Wed, 4 Nov 2020 08:40:46 +0100 [thread overview]
Message-ID: <af58eb35-189b-fcdb-be52-46a0c2c3803c@redhat.com> (raw)
In-Reply-To: <20201103151452.416784-2-pbonzini@redhat.com>
On 03/11/2020 16.14, Paolo Bonzini wrote:
> This QemuOpts idiom will be deprecated, so get rid of it in the tests.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/qtest/ivshmem-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c
> index d5c8b9f128..dfa69424ed 100644
> --- a/tests/qtest/ivshmem-test.c
> +++ b/tests/qtest/ivshmem-test.c
> @@ -135,7 +135,7 @@ static void setup_vm_cmd(IVState *s, const char *cmd, bool msix)
> static void setup_vm(IVState *s)
> {
> char *cmd = g_strdup_printf("-object memory-backend-file"
> - ",id=mb1,size=1M,share,mem-path=/dev/shm%s"
> + ",id=mb1,size=1M,share=on,mem-path=/dev/shm%s"
> " -device ivshmem-plain,memdev=mb1", tmpshm);
>
> setup_vm_cmd(s, cmd, false);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-11-04 7:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 15:14 [PATCH for-5.2 0/4] deprecate short-form boolean options Paolo Bonzini
2020-11-03 15:14 ` [PATCH for-5.2 1/4] ivshmem-test: do not use short-form boolean option Paolo Bonzini
2020-11-04 7:40 ` Thomas Huth [this message]
2020-11-04 9:12 ` Markus Armbruster
2020-11-03 15:14 ` [PATCH for-5.2 2/4] qemu-option: move help handling to get_opt_name_value Paolo Bonzini
2020-11-04 12:21 ` Markus Armbruster
2020-11-04 12:49 ` Paolo Bonzini
2020-11-03 15:14 ` [PATCH for-5.2 3/4] qtest: escape device name in device-introspect-test Paolo Bonzini
2020-11-04 7:44 ` Thomas Huth
2020-11-04 8:10 ` Paolo Bonzini
2020-11-06 13:15 ` Markus Armbruster
2020-11-06 13:23 ` Paolo Bonzini
2020-11-06 15:34 ` Markus Armbruster
2020-11-03 15:14 ` [PATCH for-5.2 4/4] qemu-option: warn for short-form boolean options Paolo Bonzini
2020-11-03 16:08 ` Daniel P. Berrangé
2020-11-03 16:18 ` Paolo Bonzini
2020-11-04 13:43 ` Markus Armbruster
2020-11-03 21:22 ` Igor Mammedov
2020-11-03 21:41 ` Paolo Bonzini
2020-11-04 11:04 ` Igor Mammedov
2020-11-03 15:33 ` [PATCH for-5.2 0/4] deprecate " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af58eb35-189b-fcdb-be52-46a0c2c3803c@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).