From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0899EB64D8 for ; Wed, 14 Jun 2023 05:20:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9Ivj-0001Ca-Cw; Wed, 14 Jun 2023 01:20:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Ivf-0001Bj-CU for qemu-devel@nongnu.org; Wed, 14 Jun 2023 01:20:24 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9Ivd-00022Z-Ah for qemu-devel@nongnu.org; Wed, 14 Jun 2023 01:20:22 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3f8d61cb36cso3083985e9.1 for ; Tue, 13 Jun 2023 22:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686720019; x=1689312019; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CYXmt1W0N7aPibpdtdMaCJnDHg/yv9PwrhSdWti+4aw=; b=xuN1XzN6iBZHMqjXh/oADQnzbbU6/2I2h+7Lmxl6Uh73sHGtVyV6Jv8IYNVO+07iy/ E47JevRoZpBcKXcKONbFww7Ghl/c657jfyElpsbnpuQBGwSnlCjzRkM3qhhjfaFQSQzv l7GGkLmVXwb2l35nYT2+KVSiBdfMIkeMTO6om0Mxtw0XS0Khj0bOP3fBgQE3hk1EBR9+ PkNiAmntN9DRE34qO9MnhhQWP+GZ4w73Un0TcDcgfpVWpz7wSNUeA7rTpUJzOFeJtP7e jyYuFoH6n5hVIZVfqb7fqnDuD9Jsu6+40E90t057dA6R3/ALBvjg8Tzy2aH8kZMMEccV PjgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686720019; x=1689312019; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CYXmt1W0N7aPibpdtdMaCJnDHg/yv9PwrhSdWti+4aw=; b=IFv4Hr3XBNr4hkPWOspTstmzSW9mJAvBOzSz3AfD/6XtQkcamjrVomd2jKhTyBe3ta NQMNskuPHdkwgRtc5h9bHq1J84SNykyZXw0cvWlpWLAMde1zg211M9tEionj2vvBkNvI ZQ9EJqKCh/QzPAclNVauqCNkor6ERdzJxRbQeW4xFx/a3F99X9ygSY4B4DTaLCuctPMb rZLSNsNAm6CAq+XwsCw4GwxiyfcFP0Mmo5+xmxMEFB1xOqE5VbgQOmV/+NCMDXxT00+k Z9LKxLHM/wXQIcvtBpl0966OEwtuqLL+ffqtEd/jtpbKH67JkNG+Ur85fqAAa5XWKuTf NoCA== X-Gm-Message-State: AC+VfDydQbsUuma+qmDA+cn0Yi262IFnvFDZ87JDwpVl8G1md5gB/Q/z f1Uo+dhiGHJzGUIPrU0aFsw17ZOXByydbxS674i2uMTz X-Google-Smtp-Source: ACHHUZ5s4JifAEbMhs1lPQe35+uZqdg+r9JB4fD1BDgLLn05OJvg/YcjMlx6lNgOwwZUiAESNPZotg== X-Received: by 2002:a05:600c:210d:b0:3f1:7581:eaaf with SMTP id u13-20020a05600c210d00b003f17581eaafmr11545987wml.4.1686720019620; Tue, 13 Jun 2023 22:20:19 -0700 (PDT) Received: from [192.168.4.112] (90-182-62-66.rcp.o2.cz. [90.182.62.66]) by smtp.gmail.com with ESMTPSA id x19-20020a1c7c13000000b003f7aad8c160sm16192943wmc.11.2023.06.13.22.20.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 22:20:18 -0700 (PDT) Message-ID: Date: Wed, 14 Jun 2023 07:20:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 04/23] target/arm: Consistently use finalize_memop_asimd() for ASIMD loads/stores Content-Language: en-US To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20230611160032.274823-1-peter.maydell@linaro.org> <20230611160032.274823-5-peter.maydell@linaro.org> From: Richard Henderson In-Reply-To: <20230611160032.274823-5-peter.maydell@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.098, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/11/23 18:00, Peter Maydell wrote: > In the recent refactoring we missed a few places which should be > calling finalize_memop_asimd() for ASIMD loads and stores but > instead are just calling finalize_memop(); fix these. > > For the disas_ldst_single_struct() and disas_ldst_multiple_struct() > cases, this is not a behaviour change because there the size > is never MO_128 and the two finalize functions do the same thing. > > Signed-off-by: Peter Maydell > --- > target/arm/tcg/translate-a64.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~