qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bibo Mao <maobibo@loongson.cn>, Song Gao <gaosong@loongson.cn>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 0/5] target/loongarch: Code cleanup with function loongarch_map_address
Date: Mon, 14 Apr 2025 12:52:12 +0200	[thread overview]
Message-ID: <af5ab3aa-f72a-4668-aa64-ae09755f0e58@linaro.org> (raw)
In-Reply-To: <20250414012528.4075447-1-maobibo@loongson.cn>

Hi Bibo,

On 14/4/25 03:25, Bibo Mao wrote:
> Get physical address from virtual address is important for qmp command to
> dump memory content. In TCG mode, it searches TLB tables firstly and
> then do page table walker. In KVM mode, there is no TLB tables and page
> table walker is used directly.
> 
> Here TLB tables searching is moved to directory tcg, and code about page
> table walker is put in common part so that it can be used in KVM mode
> also.
> 
> Bibo Mao (5):
>    target/loongarch: Move header file helper.h to directory tcg
>    target/loongarch: Add function loongarch_get_addr_from_tlb
>    target/loongarch: Move function get_dir_base_width to common directory
>    target/loongarch: Set function loongarch_map_address() with common
>      code
>    target/loongarch: Move function loongarch_tlb_search to directory tcg

Please check if changes in patches 4 & 5 need adjustment.
Otherwise for the series:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



      parent reply	other threads:[~2025-04-14 10:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14  1:25 [PATCH 0/5] target/loongarch: Code cleanup with function loongarch_map_address Bibo Mao
2025-04-14  1:25 ` [PATCH 1/5] target/loongarch: Move header file helper.h to directory tcg Bibo Mao
2025-04-15  3:22   ` Richard Henderson
2025-04-15  6:07     ` bibo mao
2025-04-14  1:25 ` [PATCH 2/5] target/loongarch: Add function loongarch_get_addr_from_tlb Bibo Mao
2025-04-14  1:25 ` [PATCH 3/5] target/loongarch: Move function get_dir_base_width to common directory Bibo Mao
2025-04-14  1:25 ` [PATCH 4/5] target/loongarch: Set function loongarch_map_address() with common code Bibo Mao
2025-04-14 10:51   ` Philippe Mathieu-Daudé
2025-04-15  1:46     ` bibo mao
2025-04-14  1:25 ` [PATCH 5/5] target/loongarch: Move function loongarch_tlb_search to directory tcg Bibo Mao
2025-04-14 10:52 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af5ab3aa-f72a-4668-aa64-ae09755f0e58@linaro.org \
    --to=philmd@linaro.org \
    --cc=gaosong@loongson.cn \
    --cc=maobibo@loongson.cn \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).