From: Richard Henderson <richard.henderson@linaro.org>
To: Damien Hedde <damien.hedde@greensocs.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, berrange@redhat.com,
ehabkost@redhat.com, cohuck@redhat.com,
mark.burton@greensocs.com, edgari@xilinx.com,
qemu-s390x@nongnu.org, pbonzini@redhat.com, philmd@redhat.com,
david@gibson.dropbear.id.au
Subject: Re: [PATCH v6 06/11] hw/core/qdev: handle parent bus change regarding resettable
Date: Sun, 29 Dec 2019 10:51:03 +1100 [thread overview]
Message-ID: <af6d26db-595b-4e39-8d9c-1bcbf338983c@linaro.org> (raw)
In-Reply-To: <20191220115035.709876-7-damien.hedde@greensocs.com>
On 12/20/19 10:50 PM, Damien Hedde wrote:
> In qdev_set_parent_bus(), when changing the parent bus of a
> realized device, if the source and destination buses are not in the
> same reset state, some adaptations are required. This patch adds
> needed call to resettable_change_parent() to make sure a device reset
> state stays coherent with its parent bus.
>
> The addition is a no-op if:
> 1. the device being parented is not realized.
> 2. the device is realized, but both buses are not under reset.
>
> Case 2 means that as long as qdev_set_parent_bus() is called
> during the machine realization procedure (which is before the
> machine reset so nothing is in reset), it is a no op.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-12-28 23:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 11:50 [PATCH v6 00/11] Multi-phase reset mechanism Damien Hedde
2019-12-20 11:50 ` [PATCH v6 01/11] add device_legacy_reset function to prepare for reset api change Damien Hedde
2019-12-20 11:50 ` [PATCH v6 02/11] hw/core/qdev: add trace events to help with resettable transition Damien Hedde
2019-12-20 11:50 ` [PATCH v6 03/11] hw/core: create Resettable QOM interface Damien Hedde
2019-12-28 23:40 ` Richard Henderson
2019-12-20 11:50 ` [PATCH v6 04/11] hw/core: add Resettable support to BusClass and DeviceClass Damien Hedde
2019-12-20 11:50 ` [PATCH v6 05/11] hw/core/resettable: add support for changing parent Damien Hedde
2019-12-28 23:47 ` Richard Henderson
2019-12-20 11:50 ` [PATCH v6 06/11] hw/core/qdev: handle parent bus change regarding resettable Damien Hedde
2019-12-28 23:51 ` Richard Henderson [this message]
2019-12-20 11:50 ` [PATCH v6 07/11] hw/core/qdev: update hotplug reset " Damien Hedde
2019-12-28 23:58 ` Richard Henderson
2020-01-13 16:51 ` Damien Hedde
2019-12-20 11:50 ` [PATCH v6 08/11] hw/core: deprecate old reset functions and introduce new ones Damien Hedde
2019-12-29 0:00 ` Richard Henderson
2019-12-20 11:50 ` [PATCH v6 09/11] docs/devel/reset.rst: add doc about Resettable interface Damien Hedde
2019-12-29 0:02 ` Richard Henderson
2019-12-20 11:50 ` [PATCH v6 10/11] vl: replace deprecated qbus_reset_all registration Damien Hedde
2019-12-29 0:04 ` Richard Henderson
2019-12-20 11:50 ` [PATCH v6 11/11] hw/s390x/ipl: replace deprecated qdev_reset_all registration Damien Hedde
2019-12-29 0:05 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af6d26db-595b-4e39-8d9c-1bcbf338983c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=damien.hedde@greensocs.com \
--cc=david@gibson.dropbear.id.au \
--cc=edgari@xilinx.com \
--cc=ehabkost@redhat.com \
--cc=mark.burton@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).