From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DF62EE7FF4 for ; Mon, 11 Sep 2023 09:43:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfdRw-0003aC-Oa; Mon, 11 Sep 2023 05:43:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfdRp-0003Z8-7z for qemu-devel@nongnu.org; Mon, 11 Sep 2023 05:43:13 -0400 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfdRk-0003vU-2f for qemu-devel@nongnu.org; Mon, 11 Sep 2023 05:43:11 -0400 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2bd6611873aso66636601fa.1 for ; Mon, 11 Sep 2023 02:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694425386; x=1695030186; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jmjKOQuW73CkxyzBkHVYL2o2wQ74q95ptQBD70bJNtg=; b=f2PMyopQmLdegxN/11jahK6fgxWi458StEtOphpE7uf1d5MKvhmZDw8VNQYAyzLcHk ZcSk8W5FQmAPgiXtGygsxyVced55hUK9ByW+Ml7ylsdidM63Yajv1UMyldCeZLBw4xGU THD2KQwXDYBSjDov+BqxirBP1f+fvHHPofDE2zisL431Ldn29y1liAMTLEmPsaNs5KvK Xg0vCr71+ukV3xA33VI1FIGLpxFIy7qPU15zVMgu4HVumA8OesGlItgHONd0TiGYOi+g RrZX7ojocWENrMnBcL95lx+Ryp1rVn5c0JL54WwkYFTwuImCFZigLdgjGlljWZja/1LE hIBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694425386; x=1695030186; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jmjKOQuW73CkxyzBkHVYL2o2wQ74q95ptQBD70bJNtg=; b=DrEBZqNINYuZ3gpDfaPJAaaJkfNwj4G2y9rCP4rVBP1i49/ej2d9k2UzPAmcJ+Jh+c EKZ+YtygTjIzI17CJtL5UCUX4JCelHPfesmzSBF2IU1EnS7lU1uJAjS/HET4soRw9KEX UOjjqpoovVlMocqg6BXvy4LiHVSpzP9DbT+3nnp5pw8m3r8t5UlYRvbz6Tl+x+ymuAbl NeduL0CmyNnK0cl4pEPWJsxGEPX5XkZsm4lcWf0xI0VeyvHVv8g5yJWLCzBEnpUgemc1 vf6YHPW8b+pmfLbVt4aO2ze07aVLZDna/BXNdDkTtPos6RwCeGVCjrMSkOWd/TQZ+lOe z/sA== X-Gm-Message-State: AOJu0YztScHEN0ArTCpsqnbRuAfm+2zZ4obzrrZ+CcirotE4NXcXwHPf oyj9dyrUqEyk2us6Kw1/1G1sqg== X-Google-Smtp-Source: AGHT+IFLoqhyHG+pHj53Yx1we7ufAk8ESiVUOXjmWvXEuK07T4Vo/rpqF1CLPHFjiSBLlYIKbiFa5g== X-Received: by 2002:a2e:9303:0:b0:2bd:b99:ab7e with SMTP id e3-20020a2e9303000000b002bd0b99ab7emr7401965ljh.42.1694425386023; Mon, 11 Sep 2023 02:43:06 -0700 (PDT) Received: from [192.168.69.115] (tfy62-h01-176-171-221-76.dsl.sta.abo.bbox.fr. [176.171.221.76]) by smtp.gmail.com with ESMTPSA id si28-20020a170906cedc00b009786c8249d6sm5134068ejb.175.2023.09.11.02.43.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Sep 2023 02:43:05 -0700 (PDT) Message-ID: Date: Mon, 11 Sep 2023 11:43:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 3/4] hw/cpu: Introduce CPUClass::cpu_resolving_type field Content-Language: en-US To: Gavin Shan , qemu-devel@nongnu.org, David Hildenbrand Cc: Chris Wulff , David Gibson , qemu-s390x@nongnu.org, Weiwei Li , qemu-arm@nongnu.org, Mark Cave-Ayland , Jiaxun Yang , Yoshinori Sato , Richard Henderson , Marcel Apfelbaum , Max Filippov , Nicholas Piggin , Eduardo Habkost , Ilya Leoshkevich , Bastian Koppelmann , Greg Kurz , "Edgar E. Iglesias" , qemu-ppc@nongnu.org, Daniel Henrique Barboza , Marek Vasut , Palmer Dabbelt , Michael Rolnik , Laurent Vivier , Peter Maydell , qemu-riscv@nongnu.org, Aurelien Jarno , Bin Meng , Xiaojuan Yang , Daniel Henrique Barboza , Aleksandar Rikalo , Artyom Tarasenko , Song Gao , Stafford Horne , Yanan Wang , Alistair Francis , Brian Cain , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Thomas Huth , Liu Zhiwei References: <20230908112235.75914-1-philmd@linaro.org> <20230908112235.75914-4-philmd@linaro.org> <87cb0174-c652-aa44-be7c-49e78e0a5003@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <87cb0174-c652-aa44-be7c-49e78e0a5003@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::22a; envelope-from=philmd@linaro.org; helo=mail-lj1-x22a.google.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.473, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/9/23 01:28, Gavin Shan wrote: > Hi Philippe, > > On 9/8/23 21:22, Philippe Mathieu-Daudé wrote: >> Add a field to return the QOM type name of a CPU class. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   include/hw/core/cpu.h   | 2 ++ >>   hw/core/cpu-common.c    | 2 +- >>   target/alpha/cpu.c      | 1 + >>   target/arm/cpu.c        | 1 + >>   target/avr/cpu.c        | 1 + >>   target/cris/cpu.c       | 1 + >>   target/hexagon/cpu.c    | 1 + >>   target/hppa/cpu.c       | 1 + >>   target/i386/cpu.c       | 1 + >>   target/loongarch/cpu.c  | 1 + >>   target/m68k/cpu.c       | 1 + >>   target/microblaze/cpu.c | 1 + >>   target/mips/cpu.c       | 1 + >>   target/nios2/cpu.c      | 1 + >>   target/openrisc/cpu.c   | 1 + >>   target/ppc/cpu_init.c   | 1 + >>   target/riscv/cpu.c      | 1 + >>   target/rx/cpu.c         | 1 + >>   target/s390x/cpu.c      | 1 + >>   target/sh4/cpu.c        | 1 + >>   target/sparc/cpu.c      | 1 + >>   target/tricore/cpu.c    | 1 + >>   target/xtensa/cpu.c     | 1 + >>   23 files changed, 24 insertions(+), 1 deletion(-) >> >> diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h >> index 129d179937..e469efd409 100644 >> --- a/include/hw/core/cpu.h >> +++ b/include/hw/core/cpu.h >> @@ -100,6 +100,7 @@ struct SysemuCPUOps; >>   /** >>    * CPUClass: >> + * @cpu_resolving_type: CPU QOM type name >>    * @class_by_name: Callback to map -cpu command line model name to an >>    *                 instantiatable CPU type. >>    * @parse_features: Callback to parse command line arguments. >> @@ -148,6 +149,7 @@ struct CPUClass { >>       DeviceClass parent_class; >>       /*< public >*/ >> +    const char *cpu_resolving_type; >>       ObjectClass *(*class_by_name)(const char *cpu_model); >>       void (*parse_features)(const char *typename, char *str, Error >> **errp); > > The question is why not use CPU_RESOLVING_TYPE directly? It seems > CPU_RESOLVING_TYPE > is exactly what you want here. Unfortunately CPU_RESOLVING_TYPE is target-specific, we want hw/core/cpu-common.c to be target-agnostic (build once for all targets). This is particularly important in the context of heterogeneous QEMU, where a single binary will be able to create CPUs from different targets. > Besides, I guess the changes can be > squeezed into two > patches (commits) as below: > > PATCH[1] target/alpha: Tidy up alpha_cpu_class_by_name() > PATCH[2] Move the checks (oc == NULL || object_class_is_abstract() || > !object_class_dynamic_cast()) >          from individual targets to > hw/core/cpu-common.c::cpu_class_by_name() > > I rebase my series of '[PATCH v3 00/32] Unified CPU type check' on top > of yours. Please > let me know if I need to include your patch into my v4 series for > review. In that case, > I can include your patches with above changes applied. > > Thanks, > Gavin > >> diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c >> index c6a0c9390c..2d24261a6a 100644 >> --- a/hw/core/cpu-common.c >> +++ b/hw/core/cpu-common.c >> @@ -155,7 +155,7 @@ ObjectClass *cpu_class_by_name(const char >> *typename, const char *cpu_model) >>       assert(cpu_model); >>       oc = object_class_by_name(typename); >>       cc = CPU_CLASS(oc); >> -    assert(cc->class_by_name); >> +    assert(cc->cpu_resolving_type && cc->class_by_name); >>       oc = cc->class_by_name(cpu_model); >>       if (oc == NULL || object_class_is_abstract(oc)) { >>           return NULL;