From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] tcg: Add missing tcg_can_emit_vec_op check in tcg_gen_gvec_2s
Date: Thu, 22 Feb 2018 07:32:25 -0800 [thread overview]
Message-ID: <af7f0c19-5c80-3124-e2ba-e454db06ad5a@linaro.org> (raw)
In-Reply-To: <CAFEAcA8NvZeD_eXCvP8NyA8usVy+fPKkcVnqgvnDddcNhZCLHQ@mail.gmail.com>
On 02/22/2018 06:58 AM, Peter Maydell wrote:
> Incidentally, I notice that the condition checks
> (TCG_TARGET_HAS_v256 && check_size_impl(oprsz, 32)
> && tcg_can_emit_vec_op(g->opc, TCG_TYPE_V256, g->vece))
>
> (TCG_TARGET_HAS_v128 && check_size_impl(oprsz, 16)
> && tcg_can_emit_vec_op(g->opc, TCG_TYPE_V128, g->vece))
>
> (TCG_TARGET_HAS_v64 && check_size_impl(oprsz, 8)
> && tcg_can_emit_vec_op(g->opc, TCG_TYPE_V64, g->vece))
>
> seem to be quite commonly used -- perhaps factoring these out
> into suitably named functions would make the code more readable?
That's a good idea. I'll see what I can come up with there.
r~
prev parent reply other threads:[~2018-02-22 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 16:40 [Qemu-devel] [PATCH 0/2] tcg: tcg_can_emit_vec_op cleanup+fix Richard Henderson
2018-02-17 16:40 ` [Qemu-devel] [PATCH 1/2] tcg: Fold unspecified opcode test into tcg_can_emit_vec_op Richard Henderson
2018-02-22 14:54 ` Peter Maydell
2018-02-17 16:40 ` [Qemu-devel] [PATCH 2/2] tcg: Add missing tcg_can_emit_vec_op check in tcg_gen_gvec_2s Richard Henderson
2018-02-22 14:58 ` Peter Maydell
2018-02-22 15:32 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af7f0c19-5c80-3124-e2ba-e454db06ad5a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).