From: Hanna Reitz <hreitz@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH for 6.1] tests: filter out TLS distinguished name in certificate checks
Date: Mon, 9 Aug 2021 17:35:07 +0200 [thread overview]
Message-ID: <af8f6dea-def2-c3fe-e2f3-68e5fb27fa89@redhat.com> (raw)
In-Reply-To: <20210804180330.3469683-1-berrange@redhat.com>
On 04.08.21 20:03, Daniel P. Berrangé wrote:
> The version of GNUTLS in Fedora 34 has changed the order in which encodes
> fields when generating new TLS certificates. This in turn changes the
> order seen when querying the distinguished name. This ultimately breaks
> the expected output in the NBD TLS iotests. We don't need to be
> comparing the exact distinguished name text for the purpose of the test
> though, so it is fine to filter it out.
>
> Reported-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/qemu-iotests/233 | 2 +-
> tests/qemu-iotests/233.out | 4 ++--
> tests/qemu-iotests/common.filter | 5 +++++
> 3 files changed, 8 insertions(+), 3 deletions(-)
Thanks, applied to my block branch:
https://github.com/XanClic/qemu/commits/block
(Given my email address change today, I don’t know yet how well the pull
request will go. Perhaps I’ll have to ask Kevin or Eric to step in on
this one.)
Hanna
prev parent reply other threads:[~2021-08-09 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 18:03 [PATCH for 6.1] tests: filter out TLS distinguished name in certificate checks Daniel P. Berrangé
2021-08-04 21:23 ` Eric Blake
2021-08-09 15:35 ` Hanna Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af8f6dea-def2-c3fe-e2f3-68e5fb27fa89@redhat.com \
--to=hreitz@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).