From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8416BC35254 for ; Mon, 10 Feb 2020 19:11:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4741E20715 for ; Mon, 10 Feb 2020 19:11:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B3W2MqNT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4741E20715 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1ESr-0000oy-BH for qemu-devel@archiver.kernel.org; Mon, 10 Feb 2020 14:11:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35971) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1ES4-0000D8-V7 for qemu-devel@nongnu.org; Mon, 10 Feb 2020 14:10:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1ES3-0000dC-7P for qemu-devel@nongnu.org; Mon, 10 Feb 2020 14:10:36 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:48639 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j1ES3-0000bA-4I for qemu-devel@nongnu.org; Mon, 10 Feb 2020 14:10:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581361834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vc48t+6AI7AmfL86H9V0dNN8Uqt/W69NAg/TKGozIpE=; b=B3W2MqNTriteiZZqrS7ggEMhkum7OJR2gNSvNcr0K5qPK9hDlpRSqBVlzRux3LKdzSP+av MZ6P3WomJzZ1IiipAIa7UCphaSzz9zrWfyXVSIJm3FVUYm9H9yjNKhZprTcjnK/YGmhrPK MyvBZHR8+CpkB34q7NwPfmnZZ+ZNlAc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-31-UsVvzEiaMyS2UKn1sX7t7w-1; Mon, 10 Feb 2020 14:10:30 -0500 Received: by mail-wm1-f72.google.com with SMTP id u11so162861wmb.4 for ; Mon, 10 Feb 2020 11:10:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Vc48t+6AI7AmfL86H9V0dNN8Uqt/W69NAg/TKGozIpE=; b=uI19EIqhUNQi6qqHz62GxC5kLpyE9Q+1FOJLZhj7mY80bcyZphvAh10udPbOCEPqiI 3hcsJMx95qPNCw5gTnyEHtJswY0jmMJFWUnB5niciZN20++KqTku0K8hFHb4qhCf19Y1 I1BKndpDtPApsED0+6ojFSXC2eUidKiYxwVlJFhY7I0ZcalRB8HNFA18sLAdoysZ9iOt hq3soTsFs182SlLvPyHC2Papd1+AqXDSOYri29tVbD73yQ9qPtFMxfkFa8cWNC6h6VNC jWHcyoPfkqq8hTnEv1EXvt31lQJDdqKvqKYXVhZEjiJnaGpaRxy6d1kw8ZXzBjX6Hn2D 2MrA== X-Gm-Message-State: APjAAAXCdh4nSQaRRo9EgYIUvIPFtl5v5/20Alo0CJsuW/6Ha05vX1Cu mg4ygMKxvd+Udg1Ov4SV02cEQ+ZUyaJOgdK+HZtmz/7SiGprZSwzloklAtnHqHjHcxyXsBlqa1T t2AEaKiBkujmeSoI= X-Received: by 2002:a1c:9c4c:: with SMTP id f73mr390626wme.125.1581361829061; Mon, 10 Feb 2020 11:10:29 -0800 (PST) X-Google-Smtp-Source: APXvYqzEJ49fRTUG3c2X06NrTs3kBqkSot8j0c3Mb7Is/No0Wr/2mloktsJLeXKhX2zlz41Omdd7BA== X-Received: by 2002:a1c:9c4c:: with SMTP id f73mr390589wme.125.1581361828379; Mon, 10 Feb 2020 11:10:28 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:50ec:2e9a:84be:2bbe? ([2001:b07:6468:f312:50ec:2e9a:84be:2bbe]) by smtp.gmail.com with ESMTPSA id a8sm386919wmc.20.2020.02.10.11.10.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2020 11:10:27 -0800 (PST) Subject: Re: [Libguestfs] [RFC] lib: allow to specify physical/logical block size for disks To: "Richard W.M. Jones" , Mykola Ivanets , qemu-devel@nongnu.org, qemu-block@nongnu.org References: <20200207232528.13461-1-stenavin@gmail.com> <20200210114316.GW3888@redhat.com> From: Paolo Bonzini Message-ID: Date: Mon, 10 Feb 2020 20:10:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20200210114316.GW3888@redhat.com> Content-Language: en-US X-MC-Unique: UsVvzEiaMyS2UKn1sX7t7w-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libguestfs@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/02/20 12:43, Richard W.M. Jones wrote: > So it appears that we should just have one blocksize control (maybe > called "sectorsize"?) which sets both physical_block_size and > logical_block_size to the same value. It may also be worth enforcing > that blocksize/sectorsize must be set to 512 or 4096 (which we can > relax later if necessary). Yes, physical_sector_size is basically a hint to the OS and is of rather limited usefulness. Paolo