Re: [Qemu-devel] glibc "linux: spawni.c: simplify error reporting to parent" breaks qemu-user/Windows Service For Linux

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 26/11/2017 18:35, John Paul Adrian Glaubitz wrote:
> On 11/26/2017 09:28 PM, John Paul Adrian Glaubitz wrote:
>> I'm not sure yet what the actual problem is but I thought it should be necessary
>> to point you at the problem.
> 
> Ok, there is already a QEMU bug report for this [1].
> 
> Adrian
> 
>> [1] https://bugs.launchpad.net/qemu/+bug/1673976
> 

We found out this potential bogus assert on 2.27 development [1] which
resulted in two fixes [2][3].

It should not be an issue for generic posix_spawn usage where there is
no expectation system/user/program kills random pids (since posix_spawn
auxiliary process has not yet returned). Some say the possible kind of
behaviour is rather undefined, but it shouldn't also trigger an assert.

I am not really sure what is happening in qemu usermode because comment
#4 in the bug reports states clone is returning an error and it should
not trigger the assert in first place.  What seems to be happening in
this scenario is clone is actually returning a success, but the auxiliary
process is being killed before actually calling execve.

In any case I think both fixes I pointed out (which are also on 2.26 and
2.25) should avoid the assert issue. Regarding the CLONE_VFORK support
I think we will need to address it on qemu.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=22273
[2] https://sourceware.org/git/?p=glibc.git;a=commit;h=fe05e1cb6d64dba6172249c79526f1e9af8f2bfd
[3] https://sourceware.org/git/?p=glibc.git;a=commit;h=aa95a2414e4f664ca740ad5f4a72d9145abbd426