From: "Doru Blânzeanu" <dblanzeanu@linux.microsoft.com>
To: Magnus Kulke <magnuskulke@linux.microsoft.com>
Cc: qemu-devel@nongnu.org, Wei Liu <wei.liu@kernel.org>,
Zhao Liu <zhao1.liu@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Wei Liu <liuwe@microsoft.com>,
Magnus Kulke <magnuskulke@microsoft.com>
Subject: Re: [PATCH v6 3/9] target/i386/mshv: fix various cpuid traversal bugs
Date: Thu, 30 Apr 2026 12:35:43 +0300 [thread overview]
Message-ID: <afMib8LRLTURZdiV@linux.microsoft.com> (raw)
In-Reply-To: <20260416121116.527927-4-magnuskulke@linux.microsoft.com>
On Thu, Apr 16, 2026 at 02:11:10PM +0200, Magnus Kulke wrote:
> - Hardcoded max_leaf was not accurate. We query leaf 0x0 and 0x80000000 to
> get the actual max leaves
>
> - On all 0 zeroes on leaf 0x0d, we register 0-63 subleaves with zeros
> indicating XSAVE is disabled
>
> - Subleaf 0 was hardcoded, so the Hypervisor returned defaults for other
> subleaves
>
> - Subleaf 0 was hardcoded, so we were passing 0 instead of actual subleaf
> when adding entries. We now pass the correct subleaf value to
> add_cpuid_entry()
>
> - Leaves 0x04,0x07,0d,0f,10 weren't marked as subleaf-specific
>
> Signed-off-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
> Acked-by: Wei Liu <wei.liu@kernel.org>
> ---
> target/i386/mshv/mshv-cpu.c | 88 +++++++++++++++++++++++++------------
> 1 file changed, 61 insertions(+), 27 deletions(-)
Reviewed-by: Doru Blânzeanu <dblanzeanu@linux.microsoft.com>
next prev parent reply other threads:[~2026-04-30 9:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 12:11 [PATCH v6 0/9] Support QEMU cpu models in MSHV accelerator Magnus Kulke
2026-04-16 12:11 ` [PATCH v6 1/9] accel/mshv: use mshv_create_partition_v2 payload Magnus Kulke
2026-04-30 8:43 ` Doru Blânzeanu
2026-04-16 12:11 ` [PATCH v6 2/9] target/i386/mshv: fix cpuid propagation bug Magnus Kulke
2026-04-30 9:05 ` Doru Blânzeanu
2026-06-28 11:24 ` Michael Tokarev
2026-06-28 11:41 ` Paolo Bonzini
2026-06-29 10:24 ` Magnus Kulke
2026-04-16 12:11 ` [PATCH v6 3/9] target/i386/mshv: fix various cpuid traversal bugs Magnus Kulke
2026-04-30 9:35 ` Doru Blânzeanu [this message]
2026-04-16 12:11 ` [PATCH v6 4/9] target/i386/mshv: change cpuid mask to UINT32_MAX Magnus Kulke
2026-04-30 11:27 ` Doru Blânzeanu
2026-04-16 12:11 ` [PATCH v6 5/9] target/i386/mshv: set cpu model name on -cpu host Magnus Kulke
2026-04-30 11:47 ` Doru Blânzeanu
2026-04-16 12:11 ` [PATCH v6 6/9] target/i386: query mshv accel for supported cpuids Magnus Kulke
2026-05-06 10:41 ` Doru Blânzeanu
2026-06-25 15:16 ` Paolo Bonzini
2026-06-26 13:37 ` Magnus Kulke
2026-04-16 12:11 ` [PATCH v6 7/9] target/i386/mshv: populate xsave area offsets Magnus Kulke
2026-05-06 11:02 ` Doru Blânzeanu
2026-04-16 12:11 ` [PATCH v6 8/9] target/i386/mshv: use hv-provided [0xD,1+2].EBX Magnus Kulke
2026-05-06 11:14 ` Doru Blânzeanu
2026-04-16 12:11 ` [PATCH v6 9/9] accel/mshv: disable la57 (5lvl paging) Magnus Kulke
2026-05-06 11:24 ` Doru Blânzeanu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afMib8LRLTURZdiV@linux.microsoft.com \
--to=dblanzeanu@linux.microsoft.com \
--cc=liuwe@microsoft.com \
--cc=magnuskulke@linux.microsoft.com \
--cc=magnuskulke@microsoft.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wei.liu@kernel.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox