From: Paolo Bonzini <pbonzini@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: "Guenter Roeck" <linux@roeck-us.net>,
"Alexander Graf" <agraf@suse.de>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Pilippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH] sam460ex: Add comment explaining ignored errors from fdt operations
Date: Fri, 6 Jul 2018 14:41:18 +0200 [thread overview]
Message-ID: <afa973b5-f32e-c88e-ad2b-9edb864f6477@redhat.com> (raw)
In-Reply-To: <20180706011849.GK3450@umbus.fritz.box>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On 06/07/2018 03:18, David Gibson wrote:
>> Ok, but why would it even fail? Maybe it's not this case, but even if
>> it's not fatal for the OS, generating different device trees silently
>> seems like a recipe for Heisenbugs.
> Yes, quite. Especially since the most likely errors I can see here
> would actually indicate something has already gone horribly wrong with
> the device tree construction, so a missing clock-frequency is the
> least of our troubles.
>
> I think using _FDT() here would be a better approach.
Or qemu_fdt_setprop_cell, which is there exactly for this reason.
Volunteers needed to report it in checkpatch! :)
Paolo
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-07-06 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 13:51 [Qemu-devel] [PATCH] sam460ex: Add comment explaining ignored errors from fdt operations Guenter Roeck
2018-07-05 14:06 ` Paolo Bonzini
2018-07-06 1:18 ` David Gibson
2018-07-06 12:41 ` Paolo Bonzini [this message]
2018-07-07 21:23 ` Guenter Roeck
2018-07-09 3:55 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afa973b5-f32e-c88e-ad2b-9edb864f6477@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=linux@roeck-us.net \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).