Re: [PATCH v4] Add a comment in bios-tables-test.c to clarify the reason behind approach

[Eric Blake <eblake@redhat.com>]

On 9/24/20 4:09 AM, Ani Sinha wrote:
> A comment is added in bios-tables-test.c that explains the reasoning
> behind the process of updating the ACPI table blobs when new tests are added
> or old tests are modified or code is committed that affect tests. The
> explanation would help future contributors follow the correct process when
> making code changes that affect ACPI tables.
> 
> Signed-off-by: Ani Sinha <ani@anisinha.ca>
> Acked-by: Igor Mammedov <imammedo@redhat.com>
> ---
>   tests/qtest/bios-tables-test.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 

>    * 6. Now commit any changes to the expected binary, include diff from step 4
>    *    in commit log.
> + *    Expected binary updates needs to be a separate patch from the code that
> + *    introduces changes to ACPI tables. It lets maintainer to drop

s/maintainer to/the maintainer/

> + *    and regenerate binary updates in case of merge conflicts. Further, a code
> + *    change is easily reviewable but a binary blob is not (without doing a
> + *    diassemly).

disassembly

>    * 7. Before sending patches to the list (Contributor)
>    *    or before doing a pull request (Maintainer), make sure
>    *    tests/qtest/bios-tables-test-allowed-diff.h is empty - this will ensure
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org