Re: [PATCH v5 46/48] target/arm/tcg/tlb-insns: compile file twice (system, user)

[Pierrick Bouvier <pierrick.bouvier@linaro.org>]

On 5/5/25 11:49 AM, Richard Henderson wrote:
> On 5/4/25 18:52, Pierrick Bouvier wrote:
>> aarch64 specific code is guarded by cpu_isar_feature(aa64*), so it's
>> safe to expose it.
>>
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>> ---
>>    target/arm/tcg/tlb-insns.c | 7 -------
>>    target/arm/tcg/meson.build | 3 ++-
>>    2 files changed, 2 insertions(+), 8 deletions(-)
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 
> In an ideal world, this would only be included within the system build, since all tlb
> flushing insns are privileged.  However, it would appear helper.c needs more cleanup
> before that could happen.
>

I added the ifndef CONFIG_USER_ONLY around define_tlb_insn_regs(cpu) in 
helper.c, which allows to build this tlb-insns only for system.

> 
> r~