qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Laszlo Ersek" <lersek@redhat.com>,
	"qemu devel list" <qemu-devel@nongnu.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH 06/10] roms/Makefile.edk2: complete replacing TPM2*_ENABLE macros
Date: Tue, 8 Sep 2020 10:10:20 +0200	[thread overview]
Message-ID: <afc5ab07-441e-0752-7331-928f0889b537@redhat.com> (raw)
In-Reply-To: <20200908072939.30178-7-lersek@redhat.com>

On 9/8/20 9:29 AM, Laszlo Ersek wrote:
> At tag "edk2-stable202008", the TPM2_ENABLE and TPM2_CONFIG_ENABLE macros
> are useless (for IA32 and X64). Their roles have been absorbed by
> TPM_ENABLE and TPM_CONFIG_ENABLE, respectively. Remove the old build
> flags.
> 
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Ref: https://bugs.launchpad.net/qemu/+bug/1852196
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  roms/Makefile.edk2 | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/roms/Makefile.edk2 b/roms/Makefile.edk2
> index 7c06645c95ca..8cdf337fc1e9 100644
> --- a/roms/Makefile.edk2
> +++ b/roms/Makefile.edk2
> @@ -89,9 +89,7 @@ submodules:
>  		-D NETWORK_HTTP_BOOT_ENABLE \
>  		-D NETWORK_TLS_ENABLE \
>  		-D TPM_ENABLE \
> -		-D TPM_CONFIG_ENABLE \
> -		-D TPM2_ENABLE \
> -		-D TPM2_CONFIG_ENABLE
> +		-D TPM_CONFIG_ENABLE
>  	cp edk2/Build/OvmfIa32/DEBUG_$(call toolchain,i386)/FV/OVMF_CODE.fd $@
>  
>  ../pc-bios/edk2-i386-secure-code.fd: submodules
> @@ -104,8 +102,6 @@ submodules:
>  		-D NETWORK_TLS_ENABLE \
>  		-D TPM_ENABLE \
>  		-D TPM_CONFIG_ENABLE \
> -		-D TPM2_ENABLE \
> -		-D TPM2_CONFIG_ENABLE \
>  		-D SECURE_BOOT_ENABLE \
>  		-D SMM_REQUIRE
>  	cp edk2/Build/OvmfIa32/DEBUG_$(call toolchain,i386)/FV/OVMF_CODE.fd $@
> @@ -119,9 +115,7 @@ submodules:
>  		-D NETWORK_HTTP_BOOT_ENABLE \
>  		-D NETWORK_TLS_ENABLE \
>  		-D TPM_ENABLE \
> -		-D TPM_CONFIG_ENABLE \
> -		-D TPM2_ENABLE \
> -		-D TPM2_CONFIG_ENABLE
> +		-D TPM_CONFIG_ENABLE
>  	cp edk2/Build/OvmfX64/DEBUG_$(call toolchain,x86_64)/FV/OVMF_CODE.fd $@
>  
>  ../pc-bios/edk2-x86_64-secure-code.fd: submodules
> @@ -135,8 +129,6 @@ submodules:
>  		-D NETWORK_TLS_ENABLE \
>  		-D TPM_ENABLE \
>  		-D TPM_CONFIG_ENABLE \
> -		-D TPM2_ENABLE \
> -		-D TPM2_CONFIG_ENABLE \
>  		-D SECURE_BOOT_ENABLE \
>  		-D SMM_REQUIRE
>  	cp edk2/Build/Ovmf3264/DEBUG_$(call toolchain,x86_64)/FV/OVMF_CODE.fd $@
> 



  reply	other threads:[~2020-09-08  8:11 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08  7:29 [PATCH 00/10] edk2: adopt the edk2-stable202008 release Laszlo Ersek
2020-09-08  7:29 ` [PATCH 01/10] Makefile: remove obsolete edk2 exception from "clean" rule Laszlo Ersek
2020-09-08  8:13   ` Philippe Mathieu-Daudé
2020-09-08  7:29 ` [PATCH 02/10] roms/efirom, tests/uefi-test-tools: update edk2's own submodules first Laszlo Ersek
2020-09-08  7:29 ` [PATCH 03/10] roms/Makefile.edk2: prepare for replacing TPM2*_ENABLE macros Laszlo Ersek
2020-09-08  8:09   ` Philippe Mathieu-Daudé
2020-09-08  7:29 ` [PATCH 04/10] tests: acpi: tolerate "virt/SSDT.memhp" mismatch temporarily Laszlo Ersek
2020-09-08  8:56   ` Igor Mammedov
2020-09-08 12:02   ` Michael S. Tsirkin
2020-09-08  7:29 ` [PATCH 05/10] roms/edk2: update submodule from edk2-stable201905 to edk2-stable202008 Laszlo Ersek
2020-09-08  8:22   ` Philippe Mathieu-Daudé
2020-09-08 12:08     ` Laszlo Ersek
2020-09-10 15:32       ` Philippe Mathieu-Daudé
2020-09-10 15:44         ` Laszlo Ersek
2020-09-10 16:00           ` Philippe Mathieu-Daudé
2020-09-10 16:14             ` Laszlo Ersek
2020-09-08  7:29 ` [PATCH 06/10] roms/Makefile.edk2: complete replacing TPM2*_ENABLE macros Laszlo Ersek
2020-09-08  8:10   ` Philippe Mathieu-Daudé [this message]
2020-09-08  7:29 ` [PATCH 07/10] roms/Makefile.edk2: enable new ARM/AARCH64 flags up to edk2-stable202008 Laszlo Ersek
2020-09-08  8:11   ` Philippe Mathieu-Daudé
2020-09-08  7:29 ` [PATCH 08/10] pc-bios: refresh edk2 build artifacts for edk2-stable202008 Laszlo Ersek
2020-09-10 16:32   ` Philippe Mathieu-Daudé
2020-09-10 16:40     ` Daniel P. Berrangé
2020-09-10 17:16     ` Laszlo Ersek
2020-09-14  9:54     ` Gerd Hoffmann
2020-09-14 10:53       ` Philippe Mathieu-Daudé
2020-09-14 11:40         ` Gerd Hoffmann
2020-09-08  7:29 ` [PATCH 09/10] pc-bios: update the README file with edk2-stable202008 information Laszlo Ersek
2020-09-10 16:03   ` Philippe Mathieu-Daudé
2020-09-08  7:29 ` [PATCH 10/10] tests: acpi: update "virt/SSDT.memhp" for edk2-stable202008 Laszlo Ersek
2020-09-08  8:27   ` Philippe Mathieu-Daudé
2020-09-08 12:14     ` Laszlo Ersek
2020-09-10 16:02       ` Philippe Mathieu-Daudé
2020-09-08  8:56   ` Igor Mammedov
2020-09-08 12:03   ` Michael S. Tsirkin
2020-09-10 19:31 ` [PATCH 00/10] edk2: adopt the edk2-stable202008 release Philippe Mathieu-Daudé
2020-09-11  7:12   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afc5ab07-441e-0752-7331-928f0889b537@redhat.com \
    --to=philmd@redhat.com \
    --cc=lersek@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).