From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: jiri@resnulli.us, Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
dmitry@daynix.com
Subject: Re: [Qemu-devel] [PATCH v9 04/11] msix: check msix_init's return value
Date: Tue, 24 Jan 2017 19:18:14 +0100 [thread overview]
Message-ID: <afeb5d3c-9301-0965-6032-3d44d0a656cc@redhat.com> (raw)
In-Reply-To: <20170117175708-mutt-send-email-mst@kernel.org>
On 17/01/2017 17:01, Michael S. Tsirkin wrote:
>>> Doesn't do it for megasas & hcd-xhci, later patches will fix them.
>>>
>>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> I don't like this one, frankly. That's a bunch of code duplication.
> I suspect vfio is the only one who might reasonably get EINVAL here.
> So how about e.g. msix_validate_and_init that doesn't assert and use that
> from vfio, then switch msix_init to assert instead?
The names we use normally would be msix_init and msix_init_nofail.
Would still require a change through the whole tree, but it's more
consistent at least.
Paolo
next prev parent reply other threads:[~2017-01-24 18:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 6:18 [Qemu-devel] [PATCH v9 00/11] Convert msix_init() to error Cao jin
2017-01-17 6:18 ` [Qemu-devel] [PATCH v9 01/11] msix: Follow CODING_STYLE Cao jin
2017-01-17 6:18 ` [Qemu-devel] [PATCH v9 02/11] hcd-xhci: check & correct param before using it Cao jin
2017-01-17 6:18 ` [Qemu-devel] [PATCH v9 03/11] pci: Convert msix_init() to Error and fix callers Cao jin
2017-01-18 8:56 ` Hannes Reinecke
2017-01-17 6:18 ` [Qemu-devel] [PATCH v9 04/11] msix: check msix_init's return value Cao jin
2017-01-17 6:50 ` Cao jin
2017-01-17 16:01 ` Michael S. Tsirkin
2017-01-18 6:29 ` Cao jin
2017-01-18 15:21 ` Michael S. Tsirkin
2017-01-19 12:25 ` Cao jin
2017-01-24 18:18 ` Paolo Bonzini [this message]
2017-01-24 19:43 ` Michael S. Tsirkin
2017-01-17 6:18 ` [Qemu-devel] [PATCH v9 05/11] megasas: change behaviour of msix switch Cao jin
2017-01-18 8:56 ` Hannes Reinecke
2017-01-17 6:18 ` [Qemu-devel] [PATCH v9 06/11] hcd-xhci: " Cao jin
2017-01-17 6:18 ` [Qemu-devel] [PATCH v9 07/11] megasas: undo the overwrites of msi user configuration Cao jin
2017-01-18 8:56 ` Hannes Reinecke
2017-01-17 6:18 ` [Qemu-devel] [PATCH v9 08/11] vmxnet3: fix reference leak issue Cao jin
2017-01-17 6:18 ` [Qemu-devel] [PATCH v9 09/11] vmxnet3: remove unnecessary internal msix flag Cao jin
2017-01-17 6:18 ` [Qemu-devel] [PATCH v9 10/11] msi_init: convert assert to return -errno Cao jin
2017-01-17 6:18 ` [Qemu-devel] [PATCH v9 11/11] megasas: remove unnecessary megasas_use_msix() Cao jin
2017-01-24 17:00 ` [Qemu-devel] [PATCH v9 00/11] Convert msix_init() to error Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afeb5d3c-9301-0965-6032-3d44d0a656cc@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=dmitry@daynix.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).