From: Paolo Bonzini <pbonzini@redhat.com>
To: P J P <ppandit@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Li Qiang" <liq3ea@gmail.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Lei Sun" <slei.casper@gmail.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v1] memory: assert MemoryRegionOps callbacks are defined
Date: Fri, 19 Jun 2020 13:00:19 +0200 [thread overview]
Message-ID: <afec3585-c624-5145-687c-08ab813454cd@redhat.com> (raw)
In-Reply-To: <nycvar.YSQ.7.77.849.2006191022400.92950@xnncv>
On 19/06/20 12:48, P J P wrote:
> | - hw/nvram/nrf51_nvm.c's flash_ops which is fixed if ROMD regions are
> | changed not to require a read callback.
> |
> | - designware_pci_host_msi_ops which is broken and should have a dummy
> | read callback.
>
>
> ie. we add these routines along with the assertions here, right?
>
> Earlier patch series adds routines for nrf51_nvm and designware. I'll add
> r/w routines for tz_ppc_dummy_ops.
In this case, please add "Based-on: <MESSAGEID>" to the patch so that
it's clear to the reviewer that there are dependencies.
Thanks!
Paolo
next prev parent reply other threads:[~2020-06-19 11:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 12:12 [PATCH v1] memory: assert MemoryRegionOps callbacks are defined P J P
2020-06-18 12:36 ` no-reply
2020-06-18 13:12 ` Alex Bennée
2020-06-18 13:35 ` Paolo Bonzini
2020-06-18 14:29 ` Peter Maydell
2020-06-18 14:53 ` Paolo Bonzini
2020-06-19 10:48 ` P J P
2020-06-19 11:00 ` Paolo Bonzini [this message]
2020-06-18 14:52 ` Philippe Mathieu-Daudé
2020-06-18 13:19 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afec3585-c624-5145-687c-08ab813454cd@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=liq3ea@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=slei.casper@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).