qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] memory: assert MemoryRegionOps callbacks are defined
@ 2020-06-18 12:12 P J P
  2020-06-18 12:36 ` no-reply
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: P J P @ 2020-06-18 12:12 UTC (permalink / raw)
  To: Paolo Bonzini
  Cc: Peter Maydell, Prasad J Pandit, Alex Bennée, Li Qiang,
	QEMU Developers, Lei Sun, Alex Williamson,
	Philippe Mathieu-Daudé, David Gibson

From: Prasad J Pandit <pjp@fedoraproject.org>

When registering a MemoryRegionOps object, assert that its
read/write callback methods are defined. This avoids potential
guest crash via a NULL pointer dereference.

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
 memory.c | 5 +++++
 1 file changed, 5 insertions(+)

Update v1: add assert while registering MemoryRegionOps
  -> https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg05187.html

diff --git a/memory.c b/memory.c
index 91ceaf9fcf..6e94fd5958 100644
--- a/memory.c
+++ b/memory.c
@@ -1495,6 +1495,9 @@ void memory_region_init_io(MemoryRegion *mr,
                            const char *name,
                            uint64_t size)
 {
+    assert(ops);
+    assert(ops->read);
+    assert(ops->write);
     memory_region_init(mr, owner, name, size);
     mr->ops = ops ? ops : &unassigned_mem_ops;
     mr->opaque = opaque;
@@ -1674,6 +1677,8 @@ void memory_region_init_rom_device_nomigrate(MemoryRegion *mr,
 {
     Error *err = NULL;
     assert(ops);
+    assert(ops->read);
+    assert(ops->write);
     memory_region_init(mr, owner, name, size);
     mr->ops = ops;
     mr->opaque = opaque;
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-06-19 11:02 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-18 12:12 [PATCH v1] memory: assert MemoryRegionOps callbacks are defined P J P
2020-06-18 12:36 ` no-reply
2020-06-18 13:12 ` Alex Bennée
2020-06-18 13:35   ` Paolo Bonzini
2020-06-18 14:29     ` Peter Maydell
2020-06-18 14:53       ` Paolo Bonzini
2020-06-19 10:48     ` P J P
2020-06-19 11:00       ` Paolo Bonzini
2020-06-18 14:52   ` Philippe Mathieu-Daudé
2020-06-18 13:19 ` no-reply

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).