From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF4FCCCA472 for ; Tue, 7 Oct 2025 12:09:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v66Ur-00059i-Ft; Tue, 07 Oct 2025 08:08:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v66Ul-00059B-TP for qemu-devel@nongnu.org; Tue, 07 Oct 2025 08:08:44 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v66Ua-0002gt-0f for qemu-devel@nongnu.org; Tue, 07 Oct 2025 08:08:43 -0400 Received: by mail-wr1-x444.google.com with SMTP id ffacd0b85a97d-3ecde0be34eso3747019f8f.1 for ; Tue, 07 Oct 2025 05:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759838904; x=1760443704; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ps4oI9QLttSKbrWOR7WKh22YqmsuJTATZazy/mpBS98=; b=Sg2buhcCeIydnjhKPbgu+L+ZYK9wRX1JCsfVjTG5da3UCQjY6vP6vjItmsr7AyFJu8 GlOFehviFIF7ji/VHwpmsHE54qJ5DawQbiNamImg0/2WZb+01+spOPagy4f9qHyKCdoy NSRlycY461ra1Op4EKOtps80nFymCAbuFfOJcCBTV4LHBaKNtz5+UBfJPR0oU6O36jL4 +ifQtK3p5W5LE1ZER+hV3ck6syTQfQAQ/ZEvoKTdItGvLNuJHTSG4juTJIdLjn2yyLoT E+ycHWBBkwA5nEbBfOjLhKpJNJH3j5wODm/DT+pjv30sf5bAKWQvmPZibrOiXO+XvlMQ a3TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759838904; x=1760443704; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ps4oI9QLttSKbrWOR7WKh22YqmsuJTATZazy/mpBS98=; b=e/T91Zr4rkP4NivNuGVd1oDwDiHXJ+knHoUphvM9kYT9lhF40WgMgSSg20J3ccsdez LwwpO++uPL2wEf1/Xd9zENI8PdbdsoZAKER/F1e7yAe+YEPWTJYITmd5/LfQvgBRxGJr VVLl52Za+4QsXKpAXU+zJ2dlI29KqUF2pmm2scybWRLt20CAcV6P65uLqzf47wGQ8xXl FZ5zIJGnVNQw3tJnNbn9DteG16dTUvY0KcZczYDzPt+OugND9bYdXtTQDMKI7HqJZD31 QW4O1zeMhjeTs4BOC3c9aQpgMAYfukB/hewwtTwqxI3ukHgDALj2t5RTiL/xWSlnJ5xu +0pA== X-Forwarded-Encrypted: i=1; AJvYcCUyhFqUXopLZaRmXmoVx7TxDHspPlnV3Bzce+eGkxL6VeAO4hPjx+PUmuoV6P1HLBrp9QeLOG+eq+SI@nongnu.org X-Gm-Message-State: AOJu0YwGO+cbOx0CZ36aLwGXmzZM7PtWBwMcTifxs4DkF2mx8CpxpM9j 9bkySjFDOkZ5gU9EgwCYuXLfDfsRKXJhVLVmEdB1yqlK7eR6Sl3aiz+79QARNbotlQU= X-Gm-Gg: ASbGncvihmagrDmBE1VLvYDcI1whABFMde+6zLxCYm5fRpBGGNYX6DbPXZt2D8mI22F bkQaoxTCRmEftq1JlBwovXS5IIY39ppiSkQmLYar7kXHdd0XSNu/son6jJJg0XCHpvI+zq/zGqB S7vJLXwoNfg5/NOLoQIhlXHaUXYVXyaNy7XpM85lpYOQY8OB+DKiOUIUtP2mwOHS6ZjY+J8pXxp iZazOzQUrZIwqQz4Gf+idcoJluMmnEZi6zCNdOn2jSmKy5Nt0QmRhUwl/JbrQH+EY8koO6i7Hcg sTgB0A8AJdo609gdYGYp7oTabcesybH+0T4s0t5eqVHQlB8vee10MWXkjjToU0g7atiUDrxHOg7 6wHNJa1AWJQlRO2w5m4/yNLo2DvMmSnu+j00dkLu4tXMe2UNHTTpRu8tknQOYTnDTW7bRHtJWw/ I/mMOdeSrqJe1xoHgrWVmCOXT5JJxo X-Google-Smtp-Source: AGHT+IHjfhBg1As87QHvEfugCYUDS5WMnJKQR35fIrrruJ/++xevR3CvRqVpQHrJ/58ErE9R8ZonSA== X-Received: by 2002:a05:6000:4009:b0:425:86d1:bcc7 with SMTP id ffacd0b85a97d-42586d1c0cdmr949114f8f.23.1759838904510; Tue, 07 Oct 2025 05:08:24 -0700 (PDT) Received: from [192.168.69.221] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8f01a0sm25028853f8f.48.2025.10.07.05.08.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Oct 2025 05:08:24 -0700 (PDT) Message-ID: Date: Tue, 7 Oct 2025 14:08:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] aspeed: Don't set 'auto_create_sdcard' Content-Language: en-US To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley References: <20251003103024.1863551-1-clg@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20251003103024.1863551-1-clg@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=philmd@linaro.org; helo=mail-wr1-x444.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/10/25 12:30, Cédric Le Goater wrote: > The Aspeed machines inherited from a 'no_sdcard' attribute when first > introduced in QEMU. This attribute was later renamed to > 'auto_create_sdcard' by commit cdc8d7cadaac ("hw/boards: Rename > no_sdcard -> auto_create_sdcard") and set to 'true'. This has the > indesirable efect to automatically create SD cards at init time. > > Remove 'auto_create_sdcard' to avoid creating a SD card device. > > Cc: Philippe Mathieu-Daudé > Link: https://lore.kernel.org/qemu-devel/20250930142448.1030476-1-clg@redhat.com > Signed-off-by: Cédric Le Goater > --- > hw/arm/aspeed.c | 22 ---------------------- > 1 file changed, 22 deletions(-) Patch queued, thanks!