From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: pbonzini@redhat.com, marcandre.lureau@redhat.com,
palmer@dabbelt.com, alistair.francis@wdc.com,
christoph.muellner@vrull.eu, liwei1518@gmail.com,
daniel.barboza@oss.qualcomm.com, zhiwei_liu@linux.alibaba.com,
chao.liu.zevorn@gmail.com, jserv@ccns.ncku.edu.tw,
eleanor15x@gmail.com, qemu-devel@nongnu.org,
qemu-riscv@nongnu.org
Subject: Re: [PATCH RFC 0/5] hw/riscv: Add support for Milk-V Duo board
Date: Wed, 13 May 2026 22:56:29 +0800 [thread overview]
Message-ID: <agSQZXyIqQiF8jgk@google.com> (raw)
In-Reply-To: <CAKmqyKMbF=BxeaDRiRPhJjSmwJFnUFLHiV5jTqZc3u2J3KKwbw@mail.gmail.com>
Hi Alistair,
On Wed, May 13, 2026 at 12:27:37PM +1000, Alistair Francis wrote:
> On Tue, May 12, 2026 at 7:47 PM Kuan-Wei Chiu <visitorckw@gmail.com> wrote:
> >
> > Add initial support for the Milk-V Duo board.
> >
> > This is something I've been playing around with in my local branch, and
> > I've reached a point where the implementation is enough to boot OpenSBI
> > and reach a Linux shell using an SD card image.
>
> Great job!
>
> >
> > I am sending this as an RFC to get early feedback to understand the gap
> > between this minimal implementation and what is required for a upstream
> > merge. I plan to continue implementing missing blocks (like gpio and
> > clk/rst) in future.
>
> Overall this looks good and is going in the right direction. Being
> able to boot Linux is a great start and a good achievement.
>
> This could be submitted now, there is no requirement to add extra
> functionality to upstream it. It would be great if you could add some
> unit tests as well, so then we can test this as part of the QEMU CI.
>
Thanks for the prompt response and the review!
I'll try to add some tests and send out as v2.
Regards,
Kuan-Wei
prev parent reply other threads:[~2026-05-13 14:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 9:46 [PATCH RFC 0/5] hw/riscv: Add support for Milk-V Duo board Kuan-Wei Chiu
2026-05-12 9:46 ` [PATCH RFC 1/5] target/riscv: Add stubs for T-Head PMU CSRs Kuan-Wei Chiu
2026-05-13 2:13 ` Alistair Francis
2026-05-13 14:49 ` Kuan-Wei Chiu
2026-05-12 9:46 ` [PATCH RFC 2/5] hw/char: Add dw8250 UART Kuan-Wei Chiu
2026-05-12 9:46 ` [PATCH RFC 3/5] hw/misc: Add Sophgo CV1800B clock controller Kuan-Wei Chiu
2026-05-12 9:46 ` [PATCH RFC 4/5] hw/riscv: Add Sophgo CV1800B SoC support Kuan-Wei Chiu
2026-05-12 9:46 ` [PATCH RFC 5/5] hw/riscv: Add Milk-V Duo board support Kuan-Wei Chiu
2026-05-13 2:27 ` [PATCH RFC 0/5] hw/riscv: Add support for Milk-V Duo board Alistair Francis
2026-05-13 14:56 ` Kuan-Wei Chiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agSQZXyIqQiF8jgk@google.com \
--to=visitorckw@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=chao.liu.zevorn@gmail.com \
--cc=christoph.muellner@vrull.eu \
--cc=daniel.barboza@oss.qualcomm.com \
--cc=eleanor15x@gmail.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=liwei1518@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox