From: "Daniel P. Berrangé" <berrange@redhat.com>
To: yujun <yujun@kylinos.cn>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] crypto/x509-utils: fix gnutls error code in crt_init failure path
Date: Mon, 29 Jun 2026 12:16:30 +0100 [thread overview]
Message-ID: <akJUDtnkDQUFJM-X@redhat.com> (raw)
In-Reply-To: <20260629111026.281185-1-yujun@kylinos.cn>
On Mon, Jun 29, 2026 at 07:10:26PM +0800, yujun wrote:
> qcrypto_get_x509_cert_fingerprint() reports gnutls_strerror(ret) when
> gnutls_x509_crt_init() fails, but ret is still the initial value -1.
> Store the gnutls return code before formatting the error, matching
> other gnutls call sites in the tree.
>
> Fixes: 2183ab6251 ("crypto/x509-utils: Check for error from gnutls_x509_crt_init()")
> Signed-off-by: yujun <yujun@kylinos.cn>
> ---
> crypto/x509-utils.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
and queued.
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
prev parent reply other threads:[~2026-06-29 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 11:10 [PATCH] crypto/x509-utils: fix gnutls error code in crt_init failure path yujun
2026-06-29 11:16 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akJUDtnkDQUFJM-X@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yujun@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox