From: Jim MacArthur <jim.macarthur@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH v3 4/6] target/arm/cpu-features.h: x-rme now means GPC3
Date: Tue, 30 Jun 2026 14:15:33 +0100 [thread overview]
Message-ID: <akPBdRdfL7aE4bpQ@linaro.org> (raw)
In-Reply-To: <CAFEAcA_M0Z770FApDyhNcYaP89JP3Q8MDj5bMjYKSpmONYrr7A@mail.gmail.com>
On Mon, Jun 29, 2026 at 01:00:05PM +0100, Peter Maydell wrote:
> On Thu, 18 Jun 2026 at 17:33, Jim MacArthur <jim.macarthur@linaro.org> wrote:
> > @@ -159,8 +159,8 @@ static void cpu_arm_set_rme(Object *obj, bool value, Error **errp)
> > {
> > ARMCPU *cpu = ARM_CPU(obj);
> >
> > - /* Enable FEAT_RME_GPC2 */
> > - FIELD_DP64_IDREG(&cpu->isar, ID_AA64PFR0, RME, value ? 2 : 0);
> > + /* Enable FEAT_RME_GPC3 */
> > + FIELD_DP64_IDREG(&cpu->isar, ID_AA64PFR0, RME, value ? 3 : 0);
> > }
>
> Just noticed this, but does this mean we should now list
> FEAT_RME_GPC3 in docs/system/arm/emulation.rst ?
> (If so, we can fix that as a followup patch.)
>
> thanks
> -- PMM
I think we should, good spot. I'll follow up with another patch to do that.
Jim
next prev parent reply other threads:[~2026-06-30 13:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 16:33 [PATCH v3 0/6] target/arm: Add aarch64 GPC3 bypass windows Jim MacArthur
2026-06-18 16:33 ` [PATCH v3 1/6] target/arm/tcg/cpu64.c: Extra test for GPC3 Jim MacArthur
2026-06-18 16:33 ` [PATCH v3 2/6] target/arm: Setup new registers " Jim MacArthur
2026-06-18 16:33 ` [PATCH v3 3/6] target/arm/ptw.c: Add Granule Bypass Windows Jim MacArthur
2026-06-18 16:38 ` Richard Henderson
2026-06-18 16:33 ` [PATCH v3 4/6] target/arm/cpu-features.h: x-rme now means GPC3 Jim MacArthur
2026-06-29 12:00 ` Peter Maydell
2026-06-30 13:15 ` Jim MacArthur [this message]
2026-06-18 16:33 ` [PATCH v3 5/6] tests/tcg/aarch64/system: Alternative boot object for exception logging Jim MacArthur
2026-06-18 16:42 ` Richard Henderson
2026-06-18 16:33 ` [PATCH v3 6/6] tests/tcg/aarch64/system/gpc-test.c: Basic test for granule protection check Jim MacArthur
2026-06-23 15:18 ` [PATCH v3 0/6] target/arm: Add aarch64 GPC3 bypass windows Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akPBdRdfL7aE4bpQ@linaro.org \
--to=jim.macarthur@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox