From: BALATON Zoltan <balaton@eik.bme.hu>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] ppc440_pcix: Add dummy implementation of BRDGOPT registers
Date: Thu, 8 Mar 2018 11:26:17 +0100 (CET) [thread overview]
Message-ID: <alpine.BSF.2.21.1803081124250.30088@zero.eik.bme.hu> (raw)
In-Reply-To: <20180308061707.GP3083@umbus.fritz.box>
On Thu, 8 Mar 2018, David Gibson wrote:
> On Wed, Mar 07, 2018 at 09:43:59PM +0100, BALATON Zoltan wrote:
>> I don't know what should be the correct implementation for these so
>> these are just stored and returned as is without doing anything for
>> now only to silence warnings when u-boot accesses these registers.
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>
> I'm a bit dubious about putting in a dummy register implementation.
> Specifically, I think the case needs to be made that the dummy
> implementation is preferable to just putting up with the test errors.
>
> At the very least there should be a comment in the code indicating
> that it's just a dummy stub implementation.
Let's go with changing the error_report to qemu_log_mask(LOG_UNIMP, ...)
as suggested by Thomas instead. I'll send another patch.
Regards,
BALATON Zoltan
prev parent reply other threads:[~2018-03-08 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 20:43 [Qemu-devel] [PATCH] ppc440_pcix: Add dummy implementation of BRDGOPT registers BALATON Zoltan
2018-03-08 4:37 ` Thomas Huth
2018-03-08 6:17 ` David Gibson
2018-03-08 10:26 ` BALATON Zoltan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.21.1803081124250.30088@zero.eik.bme.hu \
--to=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).