From: Ani Sinha <ani@anisinha.ca>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
jusual@redhat.com, qemu-devel@nongnu.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] hw/pci: remove all references to find_i440fx function
Date: Sun, 18 Jul 2021 22:14:33 +0530 (IST) [thread overview]
Message-ID: <alpine.DEB.2.21.2107182213560.56222@ani-ubuntu> (raw)
In-Reply-To: <818656b2-368a-3fb5-1eca-6d9d0cedd183@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]
On Sun, 18 Jul 2021, Philippe Mathieu-Daudé wrote:
> On 7/18/21 3:16 PM, Ani Sinha wrote:
> > commit c0e427d6eb5fefc538 ("hw/acpi/ich9: Enable ACPI PCI hot-plug") removed all
> > uses of find_i440fx() function. This has been replaced by the more generic call
> > acpi_get_i386_pci_host() which maybe able to find the root bus both for i440fx
> > machine type as well as for the q35 machine type. There seems to be no more any
> > need to maintain a i440fx specific version of the api call. Remove it.
>
> Yay!
Thanks to Julia for making it happen. I was wondering when I shall see
these patches ...
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> > Tested by building from a clean tree successfully.
> >
> > Signed-off-by: Ani Sinha <ani@anisinha.ca>
> > ---
> > hw/pci-host/i440fx.c | 8 --------
> > include/hw/pci-host/i440fx.h | 1 -
> > stubs/meson.build | 1 -
> > stubs/pci-host-piix.c | 7 -------
> > 4 files changed, 17 deletions(-)
> > delete mode 100644 stubs/pci-host-piix.c
>
prev parent reply other threads:[~2021-07-18 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 13:16 [PATCH] hw/pci: remove all references to find_i440fx function Ani Sinha
2021-07-18 14:26 ` Peter Maydell
2021-07-18 16:24 ` Philippe Mathieu-Daudé
2021-07-18 16:44 ` Ani Sinha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2107182213560.56222@ani-ubuntu \
--to=ani@anisinha.ca \
--cc=f4bug@amsat.org \
--cc=jusual@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).