From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53311)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <balaton@eik.bme.hu>) id 1TUdC1-0008PD-8Y
	for qemu-devel@nongnu.org; Sat, 03 Nov 2012 08:51:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <balaton@eik.bme.hu>) id 1TUdC0-0002js-7l
	for qemu-devel@nongnu.org; Sat, 03 Nov 2012 08:51:17 -0400
Received: from mono.eik.bme.hu ([152.66.115.2]:56172)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <balaton@eik.bme.hu>) id 1TUdC0-0002jd-1C
	for qemu-devel@nongnu.org; Sat, 03 Nov 2012 08:51:16 -0400
Date: Sat, 3 Nov 2012 13:51:14 +0100 (CET)
From: BALATON Zoltan <balaton@eik.bme.hu>
In-Reply-To: <CAAu8pHuY_2KKdMy-U9NEiOB2m+MQH3W4t6y_NKV_Wa38UHP2XQ@mail.gmail.com>
Message-ID: <alpine.GSO.2.00.1211031348260.14929@mono>
References: <alpine.GSO.2.00.1210031114580.19707@mono>
	<alpine.GSO.2.00.1210062033040.13558@mono>
	<alpine.GSO.2.00.1210182104330.10567@mono>
	<alpine.GSO.2.00.1210291136220.8786@mono>
	<CAAu8pHvGDGjckR49EoSHkZTLPi9BjTmDfYXPjg0+9GG2aLVCKg@mail.gmail.com>
	<alpine.GSO.2.00.1210310206370.21558@mono>
	<alpine.GSO.2.00.1211020219290.15462@mono>
	<CAAu8pHuY_2KKdMy-U9NEiOB2m+MQH3W4t6y_NKV_Wa38UHP2XQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: Re: [Qemu-devel] [PATCH 1/4 v5] vmware_vga: Coding style cleanup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On Sat, 3 Nov 2012, Blue Swirl wrote:
> But this and the others introduce new problems:
> WARNING: suspect code indent for conditional statements (4, 9)
> #301: FILE: hw/vmware_vga.c:320:
> +    for (line = h; line > 0; line--, src += bypl, dst += bypl) {
>           memcpy(dst, src, width);
> 
> WARNING: suspect code indent for conditional statements (4, 9)
> #378: FILE: hw/vmware_vga.c:482:
> +    if (s->vga.ds->cursor_define) {
>           s->vga.ds->cursor_define(qc);
> 
> WARNING: suspect code indent for conditional statements (4, 9)
> #393: FILE: hw/vmware_vga.c:495:
> +    if (!s->config || !s->enable) {
>           return 0;
> 
> WARNING: suspect code indent for conditional statements (4, 9)
> #398: FILE: hw/vmware_vga.c:499:
> +    if (num < 0) {
>           num += CMD(max) - CMD(min);
> 
> Please recheck the patches.

I did check patches before submitting. It must have been my mailer 
mangling whitespace. Resent it again, now it should be correct at last. 
Sorry for the inconvenience.

Regards,
BALATON Zoltan