From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38711)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <balaton@eik.bme.hu>) id 1UKHTr-0002z2-1B
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 20:11:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <balaton@eik.bme.hu>) id 1UKHTm-0004kp-5p
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 20:11:10 -0400
Received: from mono.eik.bme.hu ([152.66.115.2]:64017)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <balaton@eik.bme.hu>) id 1UKHTl-0004kX-V7
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 20:11:06 -0400
Date: Tue, 26 Mar 2013 01:02:47 +0100 (CET)
From: BALATON Zoltan <balaton@eik.bme.hu>
In-Reply-To: <5150B3F0.3080003@redhat.com>
Message-ID: <alpine.GSO.2.01.1303260054490.10974@mono>
References: <1363084369-27517-1-git-send-email-kraxel@redhat.com>
	<1363084369-27517-17-git-send-email-kraxel@redhat.com>
	<515001C2.7080201@web.de> <51500302.6040506@redhat.com>
	<515003E5.7000809@web.de> <5150091D.9070209@redhat.com>
	<51500A99.7020902@web.de>
	<51500D49.5030202@redhat.com> <51500D8F.6050604@web.de>
	<51501473.3010608@redhat.com> <51501991.2080204@web.de>
	<51501D75.2090902@redhat.com> <51501F2A.9000802@web.de>
	<51502027.5030108@web.de> <515028D0.1000408@redhat.com>
	<5150572D.6090201@gmail.com>
	<CA+x0pt4w7iJ1zs7Qdmf+oxush4Q8raVqGcETExEVYm--wMeKHg@mail.gmail.com>
	<5150B3F0.3080003@redhat.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
Subject: Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in
 gfx hardware emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>, Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org

On Mon, 25 Mar 2013, Gerd Hoffmann wrote:
> No, it is not, and yes, this is where the inconsistency comes from.  We
> read wred+wgreen+wblue directly from the surface whereas depth is cached
> in the vmware vga state struct.  Patch attached.  Not fully tested yet.

Tried that before and it didn't work that time (but maybe things have 
improved since). I could not find the "Problem" but you might look at
http://lists.nongnu.org/archive/html/qemu-devel/2012-11/msg00512.html
and commit 1f202568e0553b416483e5993f1bde219c22cf72 for the symptoms and 
why these were added back after being removed shortly. If these are not 
relevant any more just ignore this message (or use it to get rid of the 
dummy depth variable in your patch).

Regards,
BALATON Zoltan